Daimona / BotRiconferme

includes/Task/Subtask/UpdatesAround.php

Spacing +7 added lines, -7 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getCreatedPages();
 
 		if ( !$pages ) {
@@ -36,7 +36,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToMainPage( array $pages ) {
+	protected function addToMainPage ( array $pages ) {
 		$this->getLogger()->info(
 			'Adding the following to main: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
@@ -63,7 +63,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addVote( array $pages ) {
+	protected function addVote ( array $pages ) {
 		$this->getLogger()->info(
 			'Adding the following to votes: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
@@ -92,7 +92,7 @@ 
 			$beforeReg = '!INSERIRE LA NOTIZIA PIÙ NUOVA IN CIMA.+!m';
 			// Replace semicolon with full stop
 			$newLines = substr( $newLines, 0, -2 ) . ".\n";
-			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[0]}\n$newLines", $content, 1 );
+			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[ 0 ]}\n$newLines", $content, 1 );
 		}
 
 		$summary = $this->msg( 'ric-vote-page-summary' )
@@ -111,7 +111,7 @@ 
 	 *
 	 * @param int $amount
 	 */
-	protected function addNews( int $amount ) {
+	protected function addNews ( int $amount ) {
 		$this->getLogger()->info( "Increasing the news counter by $amount" );
 		$newsPage = new Page( $this->getConfig()->get( 'ric-news-page' ) );
 
@@ -124,7 +124,7 @@ 
 			throw new TaskException( 'Param not found in news page' );
 		}
 
-		$newNum = (int)$matches[2] + $amount;
+		$newNum = (int)$matches[ 2 ] + $amount;
 		$newContent = preg_replace( $reg, '${1}' . $newNum, $content );
 
 		$summary = $this->msg( 'ric-news-page-summary' )

includes/Task/Subtask/ArchivePages.php

Spacing +12 added lines, -12 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getPagesToClose();
 		$this->removeFromMainPage( $pages );
 		$this->addToArchive( $pages );
@@ -27,15 +27,15 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addToMainPage()
 	 */
-	protected function removeFromMainPage( array $pages ) {
+	protected function removeFromMainPage ( array $pages ) {
 		$this->getLogger()->info(
 			'Removing from main: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 
 		$mainPage = new Page( $this->getConfig()->get( 'ric-main-page' ) );
-		$remove = [];
+		$remove = [ ];
 		foreach ( $pages as $page ) {
-			$remove[] = '{{' . $page->getTitle() . '}}';
+			$remove[ ] = '{{' . $page->getTitle() . '}}';
 		}
 
 		$mainPage->edit( [
@@ -49,17 +49,17 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToArchive( array $pages ) {
+	protected function addToArchive ( array $pages ) {
 		$this->getLogger()->info(
 			'Adding to archive: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 
-		$simple = $votes = [];
+		$simple = $votes = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
-				$votes[] = $page;
+				$votes[ ] = $page;
 			} else {
-				$simple[] = $page;
+				$simple[ ] = $page;
 			}
 		}
 
@@ -76,14 +76,14 @@ 
 	 * @param string $archiveTitle
 	 * @param array $pages
 	 */
-	private function reallyAddToArchive( string $archiveTitle, array $pages ) {
+	private function reallyAddToArchive ( string $archiveTitle, array $pages ) {
 		$archivePage = new Page( "$archiveTitle/" . date( 'Y' ) );
 
 		$append = '';
-		$archivedList = [];
+		$archivedList = [ ];
 		foreach ( $pages as $page ) {
 			$append .= '{{' . $page->getTitle() . "}}\n";
-			$archivedList[] = $page->getUserNum();
+			$archivedList[ ] = $page->getUserNum();
 		}
 
 		$summary = $this->msg( 'close-archive-summary' )

includes/Task/CloseOld.php

Spacing +3 added lines, -3 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,7 +15,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$orderedList = [
 			'close-pages',
 			'archive-pages',
@@ -34,7 +34,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		return [
 			'archive-pages' => ArchivePages::class,
 			'close-pages' => ClosePages::class,

includes/Task/UpdateList.php

Spacing +18 added lines, -18 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -18,15 +18,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$this->actualList = $this->getActualAdmins();
 		$this->botList = $this->getDataProvider()->getUsersList();
 
@@ -55,7 +55,7 @@ 
 	/**
 	 * @return array
 	 */
-	protected function getActualAdmins() : array {
+	protected function getActualAdmins () : array {
 		$this->getLogger()->debug( 'Retrieving admins - API' );
 		$params = [
 			'action' => 'query',
@@ -73,8 +73,8 @@ 
 	 * @param \stdClass $data
 	 * @return array
 	 */
-	protected function extractAdmins( \stdClass $data ) : array {
-		$ret = [];
+	protected function extractAdmins ( \stdClass $data ) : array {
+		$ret = [ ];
 		$blacklist = $this->getConfig()->get( 'exclude-admins' );
 		foreach ( $data->query->allusers as $u ) {
 			if ( in_array( $u->name, $blacklist ) ) {
@@ -91,22 +91,22 @@ 
 	 *
 	 * @return array[]
 	 */
-	protected function getMissingGroups() : array {
-		$missing = [];
+	protected function getMissingGroups () : array {
+		$missing = [ ];
 		foreach ( $this->actualList as $adm => $groups ) {
-			$groupsList = [];
+			$groupsList = [ ];
 			if ( !isset( $this->botList[ $adm ] ) ) {
 				$groupsList = $groups;
-			} elseif ( count( $groups ) > count( $this->botList[$adm] ) ) {
+			} elseif ( count( $groups ) > count( $this->botList[ $adm ] ) ) {
 				// Only some groups are missing
-				$groupsList = array_diff_key( $groups, $this->botList[$adm] );
+				$groupsList = array_diff_key( $groups, $this->botList[ $adm ] );
 			}
 
 			foreach ( $groupsList as $group ) {
 				try {
 					$missing[ $adm ][ $group ] = $this->getFlagDate( $adm, $group );
 				} catch ( TaskException $e ) {
-					$this->errors[] = $e->getMessage();
+					$this->errors[ ] = $e->getMessage();
 				}
 			}
 		}
@@ -121,7 +121,7 @@ 
 	 * @return string
 	 * @throws TaskException
 	 */
-	protected function getFlagDate( string $admin, string $group ) : string {
+	protected function getFlagDate ( string $admin, string $group ) : string {
 		$this->getLogger()->info( "Retrieving $group flag date for $admin" );
 
 		$url = DEFAULT_URL;
@@ -156,7 +156,7 @@ 
 	 * @param string $group
 	 * @return string|null
 	 */
-	private function extractTimestamp( \stdClass $data, string $group ) : ?string {
+	private function extractTimestamp ( \stdClass $data, string $group ) : ?string {
 		$ts = null;
 		foreach ( $data->query->logevents as $entry ) {
 			if ( !isset( $entry->params ) ) {
@@ -178,8 +178,8 @@ 
 	 *
 	 * @return array[]
 	 */
-	protected function getExtraGroups() : array {
-		$extra = [];
+	protected function getExtraGroups () : array {
+		$extra = [ ];
 		foreach ( $this->botList as $name => $groups ) {
 			if ( !isset( $this->actualList[ $name ] ) ) {
 				$extra[ $name ] = $groups;
@@ -197,7 +197,7 @@ 
 	 * @param array[] $extra
 	 * @return array[]
 	 */
-	protected function getNewContent( array $missing, array $extra ) : array {
+	protected function getNewContent ( array $missing, array $extra ) : array {
 		$newContent = $this->botList;
 		foreach ( $newContent as $user => $groups ) {
 			if ( isset( $missing[ $user ] ) ) {

includes/Task/Subtask/UserNotice.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -11,7 +11,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getCreatedPages();
 		$users = $this->getDataProvider()->getUsersToProcess();
 
@@ -19,7 +19,7 @@ 
 			return TaskResult::STATUS_NOTHING;
 		}
 
-		$ricNums = [];
+		$ricNums = [ ];
 		foreach ( $pages as $page ) {
 			$ricNums[ $page->getUser() ] = $page->getNum();
 		}
@@ -37,7 +37,7 @@ 
 	 * @param string $user
 	 * @param int $ricNum
 	 */
-	protected function addMsg( string $user, int $ricNum ) {
+	protected function addMsg ( string $user, int $ricNum ) {
 		$this->getLogger()->info( "Leaving msg to $user" );
 		$msg = $this->msg( 'user-notice-msg' )->params( [ '$num' => $ricNum ] )->text();
 

includes/TaskResult.php

Spacing +9 added lines, -9 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -21,7 +21,7 @@ 
 	 * @param int $status One of the Task::STATUS_* constants
 	 * @param string[] $errors
 	 */
-	public function __construct( int $status, array $errors = [] ) {
+	public function __construct ( int $status, array $errors = [ ] ) {
 		$this->status = $status;
 		$this->errors = $errors;
 	}
@@ -29,21 +29,21 @@ 
 	/**
 	 * @return int
 	 */
-	public function getStatus() : int {
+	public function getStatus () : int {
 		return $this->status;
 	}
 
 	/**
 	 * @return string[]
 	 */
-	public function getErrors() {
+	public function getErrors () {
 		return $this->errors;
 	}
 
 	/**
 	 * @param TaskResult $that
 	 */
-	public function merge( TaskResult $that ) {
+	public function merge ( TaskResult $that ) {
 		$this->status |= $that->status;
 		$this->errors = array_merge( $this->errors, $that->errors );
 	}
@@ -51,15 +51,15 @@ 
 	/**
 	 * @return string
 	 */
-	public function __toString() {
+	public function __toString () {
 		if ( $this->isOK() ) {
 			$stat = 'OK';
 			$errs = "\tNo errors.";
 		} else {
 			$stat = 'ERROR';
-			$formattedErrs = [];
+			$formattedErrs = [ ];
 			foreach ( $this->errors as $err ) {
-				$formattedErrs[] = "\t - $err";
+				$formattedErrs[ ] = "\t - $err";
 			}
 			$errs = implode( "\n", $formattedErrs );
 		}
@@ -71,7 +71,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isOK() : bool {
+	public function isOK () : bool {
 		return ( $this->status | self::STATUS_GOOD ) === self::STATUS_GOOD;
 	}
 }

includes/Task/StartNew.php

Spacing +3 added lines, -3 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$orderedList = [
 			'create-pages',
 			'updates-around',
@@ -32,7 +32,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap() : array {
+	protected function getSubtasksMap () : array {
 		return [
 			'create-pages' => CreatePages::class,
 			'updates-around' => UpdatesAround::class,

includes/Page/PageRiconferma.php

Spacing +18 added lines, -18 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Page;
 
@@ -21,7 +21,7 @@ 
 	/**
 	 * @param string $title
 	 */
-	public function __construct( string $title ) {
+	public function __construct ( string $title ) {
 		parent::__construct( $title );
 		$this->supportSection = $this->isVote() ? 3 : 0;
 		$this->opposeSection = $this->isVote() ? 4 : 3;
@@ -32,8 +32,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getUser() : string {
-		return explode( '/', $this->title )[2];
+	public function getUser () : string {
+		return explode( '/', $this->title )[ 2 ];
 	}
 
 	/**
@@ -41,7 +41,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getNum() : int {
+	public function getNum () : int {
 		$bits = explode( '/', $this->getTitle() );
 		return intval( end( $bits ) );
 	}
@@ -51,8 +51,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getUserNum() : string {
-		return explode( '/', $this->getTitle(), 3 )[2];
+	public function getUserNum () : string {
+		return explode( '/', $this->getTitle(), 3 )[ 2 ];
 	}
 
 	/**
@@ -60,7 +60,7 @@ 
 	 *
 	 * @return string
 	 */
-	public function getBaseTitle() : string {
+	public function getBaseTitle () : string {
 		// @phan-suppress-next-line PhanTypeMismatchArgumentInternal Phan bug
 		return substr( $this->getTitle(), 0, strrpos( $this->getTitle(), '/' ) );
 	}
@@ -70,7 +70,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getOpposingCount() : int {
+	public function getOpposingCount () : int {
 		return $this->getCountForSection( $this->opposeSection );
 	}
 
@@ -80,7 +80,7 @@ 
 	 * @return int
 	 * @throws \BadMethodCallException
 	 */
-	public function getSupportCount() : int {
+	public function getSupportCount () : int {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'Cannot get support for a non-vote page.' );
 		}
@@ -93,7 +93,7 @@ 
 	 * @param int $secNum
 	 * @return int
 	 */
-	protected function getCountForSection( int $secNum ) : int {
+	protected function getCountForSection ( int $secNum ) : int {
 		$content = $this->controller->getPageContent( $this->title, $secNum );
 		// Let's hope that this is good enough...
 		return substr_count( $content, "\n\# *(?![#*])" );
@@ -104,9 +104,9 @@ 
 	 *
 	 * @return int
 	 */
-	protected function getQuorum() : int {
+	protected function getQuorum () : int {
 		$reg = "!soddisfare il \[\[[^|\]]+\|quorum]] di '''(\d+) voti'''!";
-		return intval( $this->getMatch( $reg )[1] );
+		return intval( $this->getMatch( $reg )[ 1 ] );
 	}
 
 	/**
@@ -114,7 +114,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function hasOpposition() : bool {
+	public function hasOpposition () : bool {
 		return $this->getOpposingCount() >= 15;
 	}
 
@@ -124,7 +124,7 @@ 
 	 * @return int One of the OUTCOME_* constants
 	 * @throws \BadMethodCallException
 	 */
-	public function getOutcome() : int {
+	public function getOutcome () : int {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'Cannot get outcome for a non-vote page.' );
 		}
@@ -144,7 +144,7 @@ 
 	 * @throws \BadMethodCallException
 	 * @throws \LogicException
 	 */
-	public function getOutcomeText() : string {
+	public function getOutcomeText () : string {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'No need for an outcome text.' );
 		}
@@ -178,7 +178,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isVote() : bool {
+	public function isVote () : bool {
 		$sectionReg = '/<!-- SEZIONE DA UTILIZZARE PER/';
 		return !$this->matches( $sectionReg );
 	}
@@ -188,7 +188,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getEndTimestamp() : int {
+	public function getEndTimestamp () : int {
 		if ( $this->isVote() ) {
 			$reg = "!La votazione ha inizio il.+ e ha termine.+ '''([^']+)''' alle ore '''([^']+)'''!";
 			list( , $day, $hours ) = $this->getMatch( $reg );

includes/Exception/MissingSectionException.php

Spacing +2 added lines, -2 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Exception;
 
@@ -10,7 +10,7 @@ 
 	 * @param string $title
 	 * @param int|string $section Number or title
 	 */
-	public function __construct( string $title = '[unavailable]', $section = '[unavailable]' ) {
+	public function __construct ( string $title = '[unavailable]', $section = '[unavailable]' ) {
 		parent::__construct( "The section $section in the page $title doesn't exist." );
 	}
 }