Passed
Push — master ( 1bc13d...2b258e )
by Daimona
01:36
created
includes/Task/Subtask/ArchivePages.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 	/**
15 15
 	 * @inheritDoc
16 16
 	 */
17
-	public function runInternal() : int {
17
+	public function runInternal () : int {
18 18
 		$pages = $this->getDataProvider()->getPagesToClose();
19 19
 
20 20
 		if ( !$pages ) {
@@ -33,15 +33,15 @@  discard block
 block discarded – undo
33 33
 	 * @param PageRiconferma[] $pages
34 34
 	 * @see UpdatesAround::addToMainPage()
35 35
 	 */
36
-	protected function removeFromMainPage( array $pages ) {
36
+	protected function removeFromMainPage ( array $pages ) {
37 37
 		$this->getLogger()->info(
38 38
 			'Removing from main: ' . implode( ', ', array_map( 'strval', $pages ) )
39 39
 		);
40 40
 
41 41
 		$mainPage = new Page( $this->getConfig()->get( 'main-page-title' ) );
42
-		$remove = [];
42
+		$remove = [ ];
43 43
 		foreach ( $pages as $page ) {
44
-			$remove[] = '{{' . $page->getTitle() . '}}';
44
+			$remove[ ] = '{{' . $page->getTitle() . '}}';
45 45
 		}
46 46
 
47 47
 		$mainPage->edit( [
@@ -55,17 +55,17 @@  discard block
 block discarded – undo
55 55
 	 *
56 56
 	 * @param PageRiconferma[] $pages
57 57
 	 */
58
-	protected function addToArchive( array $pages ) {
58
+	protected function addToArchive ( array $pages ) {
59 59
 		$this->getLogger()->info(
60 60
 			'Adding to archive: ' . implode( ', ', array_map( 'strval', $pages ) )
61 61
 		);
62 62
 
63
-		$simple = $votes = [];
63
+		$simple = $votes = [ ];
64 64
 		foreach ( $pages as $page ) {
65 65
 			if ( $page->isVote() ) {
66
-				$votes[] = $page;
66
+				$votes[ ] = $page;
67 67
 			} else {
68
-				$simple[] = $page;
68
+				$simple[ ] = $page;
69 69
 			}
70 70
 		}
71 71
 
@@ -82,14 +82,14 @@  discard block
 block discarded – undo
82 82
 	 * @param string $archiveTitle
83 83
 	 * @param array $pages
84 84
 	 */
85
-	private function reallyAddToArchive( string $archiveTitle, array $pages ) {
85
+	private function reallyAddToArchive ( string $archiveTitle, array $pages ) {
86 86
 		$archivePage = new Page( "$archiveTitle/" . date( 'Y' ) );
87 87
 
88 88
 		$append = '';
89
-		$archivedList = [];
89
+		$archivedList = [ ];
90 90
 		foreach ( $pages as $page ) {
91 91
 			$append .= '{{' . $page->getTitle() . "}}\n";
92
-			$archivedList[] = $page->getUserNum();
92
+			$archivedList[ ] = $page->getUserNum();
93 93
 		}
94 94
 
95 95
 		$summary = $this->msg( 'close-archive-summary' )
Please login to merge, or discard this patch.
includes/Task/Subtask/CreatePages.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 	/**
15 15
 	 * @inheritDoc
16 16
 	 */
17
-	public function runInternal() : int {
17
+	public function runInternal () : int {
18 18
 		$users = $this->getDataProvider()->getUsersToProcess();
19 19
 
20 20
 		if ( !$users ) {
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	 * @param string $user
35 35
 	 * @param array $groups
36 36
 	 */
37
-	protected function processUser( string $user, array $groups ) {
37
+	protected function processUser ( string $user, array $groups ) {
38 38
 		try {
39 39
 			$num = $this->getLastPageNum( $user ) + 1;
40 40
 		} catch ( TaskException $e ) {
@@ -66,9 +66,9 @@  discard block
 block discarded – undo
66 66
 	 * @return int
67 67
 	 * @throws TaskException
68 68
 	 */
69
-	protected function getLastPageNum( string $user ) : int {
69
+	protected function getLastPageNum ( string $user ) : int {
70 70
 		$this->getLogger()->debug( "Retrieving previous pages for $user" );
71
-		$unprefixedTitle = explode( ':', $this->getConfig()->get( 'main-page-title' ), 2 )[1];
71
+		$unprefixedTitle = explode( ':', $this->getConfig()->get( 'main-page-title' ), 2 )[ 1 ];
72 72
 		$params = [
73 73
 			'action' => 'query',
74 74
 			'list' => 'allpages',
@@ -103,13 +103,13 @@  discard block
 block discarded – undo
103 103
 	 * @param string $user
104 104
 	 * @param array $groups
105 105
 	 */
106
-	protected function createPage( string $title, string $user, array $groups ) {
106
+	protected function createPage ( string $title, string $user, array $groups ) {
107 107
 		$this->getLogger()->info( "Creating page $title" );
108 108
 		$textParams = [
109 109
 			'$user' => $user,
110
-			'$date' => $groups['sysop'],
111
-			'$burocrate' => $groups['bureaucrat'] ?? '',
112
-			'$checkuser' => $groups['checkuser'] ?? ''
110
+			'$date' => $groups[ 'sysop' ],
111
+			'$burocrate' => $groups[ 'bureaucrat' ] ?? '',
112
+			'$checkuser' => $groups[ 'checkuser' ] ?? ''
113 113
 		];
114 114
 
115 115
 		$params = [
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 	 * @param string $title
128 128
 	 * @param string $newText
129 129
 	 */
130
-	protected function createBasePage( string $title, string $newText ) {
130
+	protected function createBasePage ( string $title, string $newText ) {
131 131
 		$this->getLogger()->info( "Creating base page $title" );
132 132
 
133 133
 		$params = [
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 * @param string $title
145 145
 	 * @param string $newText
146 146
 	 */
147
-	protected function updateBasePage( string $title, string $newText ) {
147
+	protected function updateBasePage ( string $title, string $newText ) {
148 148
 		$this->getLogger()->info( "Updating base page $title" );
149 149
 
150 150
 		$params = [
Please login to merge, or discard this patch.
includes/Task/Subtask/SimpleUpdates.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 	/**
15 15
 	 * @inheritDoc
16 16
 	 */
17
-	public function runInternal() : int {
17
+	public function runInternal () : int {
18 18
 		$pages = $this->getDataProvider()->getPagesToClose();
19 19
 
20 20
 		if ( !$pages ) {
@@ -33,15 +33,15 @@  discard block
 block discarded – undo
33 33
 	 * @param PageRiconferma[] $pages
34 34
 	 * @see UpdatesAround::addVote()
35 35
 	 */
36
-	protected function updateVote( array $pages ) {
36
+	protected function updateVote ( array $pages ) {
37 37
 		$this->getLogger()->info(
38 38
 			'Updating votazioni: ' . implode( ', ', array_map( 'strval', $pages ) )
39 39
 		);
40 40
 		$votePage = new Page( $this->getConfig()->get( 'vote-page-title' ) );
41 41
 
42
-		$titles = [];
42
+		$titles = [ ];
43 43
 		foreach ( $pages as $page ) {
44
-			$titles[] = preg_quote( $page->getTitle() );
44
+			$titles[ ] = preg_quote( $page->getTitle() );
45 45
 		}
46 46
 
47 47
 		$titleReg = implode( '|', $titles );
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 	 * @param array $pages
71 71
 	 * @see UpdatesAround::addNews()
72 72
 	 */
73
-	protected function updateNews( array $pages ) {
73
+	protected function updateNews ( array $pages ) {
74 74
 		$simpleAmount = $voteAmount = 0;
75 75
 		foreach ( $pages as $page ) {
76 76
 			if ( $page->isVote() ) {
@@ -93,8 +93,8 @@  discard block
 block discarded – undo
93 93
 		$simpleMatches = $newsPage->getMatch( $simpleReg );
94 94
 		$voteMatches = $newsPage->getMatch( $voteReg );
95 95
 
96
-		$newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
97
-		$newVote = (int)$voteMatches[2] - $voteAmount ?: '';
96
+		$newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
97
+		$newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
98 98
 		$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $content );
99 99
 		$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
100 100
 
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 	 *
113 113
 	 * @param PageRiconferma[] $pages
114 114
 	 */
115
-	protected function updateAdminList( array $pages ) {
115
+	protected function updateAdminList ( array $pages ) {
116 116
 		$this->getLogger()->info(
117 117
 			'Updating admin list: ' . implode( ', ', array_map( 'strval', $pages ) )
118 118
 		);
@@ -120,17 +120,17 @@  discard block
 block discarded – undo
120 120
 		$newContent = $adminsPage->getContent();
121 121
 		$newDate = date( 'Ymd', strtotime( '+1 year' ) );
122 122
 
123
-		$riconfNames = $removeNames = [];
123
+		$riconfNames = $removeNames = [ ];
124 124
 		foreach ( $pages as $page ) {
125 125
 			$user = $page->getUser();
126 126
 			$reg = "!(\{\{Amministratore\/riga\|$user.+\| *)\d+( *\|(?: *pausa)? *\}\}\n)!";
127 127
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
128 128
 				// Remove the line
129 129
 				$newContent = preg_replace( $reg, '', $newContent );
130
-				$removeNames[] = $user;
130
+				$removeNames[ ] = $user;
131 131
 			} else {
132 132
 				$newContent = preg_replace( $reg, '$1' . $newDate . '$2', $newContent );
133
-				$riconfNames[] = $user;
133
+				$riconfNames[ ] = $user;
134 134
 			}
135 135
 		}
136 136
 
@@ -150,13 +150,13 @@  discard block
 block discarded – undo
150 150
 	/**
151 151
 	 * @param PageRiconferma[] $pages
152 152
 	 */
153
-	protected function updateCUList( array $pages ) {
153
+	protected function updateCUList ( array $pages ) {
154 154
 		$this->getLogger()->info( 'Checking if CU list needs updating.' );
155 155
 		$cuList = new Page( $this->getConfig()->get( 'cu-list-title' ) );
156 156
 		$admins = $this->getDataProvider()->getUsersList();
157 157
 		$newContent = $cuList->getContent();
158 158
 
159
-		$riconfNames = $removeNames = [];
159
+		$riconfNames = $removeNames = [ ];
160 160
 		foreach ( $pages as $page ) {
161 161
 			$user = $page->getUser();
162 162
 			if ( array_key_exists( 'checkuser', $admins[ $user ] ) ) {
@@ -164,10 +164,10 @@  discard block
 block discarded – undo
164 164
 				if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
165 165
 					// Remove the line
166 166
 					$newContent = preg_replace( $reg, '', $newContent );
167
-					$removeNames[] = $user;
167
+					$removeNames[ ] = $user;
168 168
 				} else {
169 169
 					$newContent = preg_replace( $reg, '$1{{subst:#time:j F Y}}$2', $newContent );
170
-					$riconfNames[] = $user;
170
+					$riconfNames[ ] = $user;
171 171
 				}
172 172
 			}
173 173
 		}
Please login to merge, or discard this patch.
includes/Task/Subtask/FailedUpdates.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 	/**
15 15
 	 * @inheritDoc
16 16
 	 */
17
-	public function runInternal() : int {
17
+	public function runInternal () : int {
18 18
 		$failed = $this->getFailures();
19 19
 		if ( $failed ) {
20 20
 			$this->updateBurList( $failed );
@@ -31,12 +31,12 @@  discard block
 block discarded – undo
31 31
 	 *
32 32
 	 * @return PageRiconferma[]
33 33
 	 */
34
-	private function getFailures() : array {
35
-		$ret = [];
34
+	private function getFailures () : array {
35
+		$ret = [ ];
36 36
 		$allPages = $this->getDataProvider()->getPagesToClose();
37 37
 		foreach ( $allPages as $page ) {
38 38
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
39
-				$ret[] = $page;
39
+				$ret[ ] = $page;
40 40
 			}
41 41
 		}
42 42
 		return $ret;
@@ -45,17 +45,17 @@  discard block
 block discarded – undo
45 45
 	/**
46 46
 	 * @param PageRiconferma[] $pages
47 47
 	 */
48
-	protected function updateBurList( array $pages ) {
48
+	protected function updateBurList ( array $pages ) {
49 49
 		$this->getLogger()->info( 'Checking if bur list needs updating.' );
50 50
 		$admins = $this->getDataProvider()->getUsersList();
51 51
 
52
-		$remove = [];
52
+		$remove = [ ];
53 53
 		foreach ( $pages as $page ) {
54 54
 			$user = $page->getUser();
55 55
 			if ( array_key_exists( 'bureaucrat', $admins[ $user ] ) &&
56 56
 				$page->getOutcome() & PageRiconferma::OUTCOME_FAIL
57 57
 			) {
58
-				$remove[] = $user;
58
+				$remove[ ] = $user;
59 59
 			}
60 60
 		}
61 61
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	 *
86 86
 	 * @param PageRiconferma[] $pages
87 87
 	 */
88
-	protected function requestRemoval( array $pages ) {
88
+	protected function requestRemoval ( array $pages ) {
89 89
 		$this->getLogger()->info(
90 90
 			'Requesting removal on meta for: ' . implode( ', ', array_map( 'strval', $pages ) )
91 91
 		);
@@ -124,14 +124,14 @@  discard block
 block discarded – undo
124 124
 	 *
125 125
 	 * @param PageRiconferma[] $pages
126 126
 	 */
127
-	protected function updateAnnunci( array $pages ) {
127
+	protected function updateAnnunci ( array $pages ) {
128 128
 		$this->getLogger()->info( 'Updating annunci' );
129 129
 
130
-		$names = [];
130
+		$names = [ ];
131 131
 		$text = '';
132 132
 		foreach ( $pages as $page ) {
133 133
 			$user = $page->getUser();
134
-			$names[] = $user;
134
+			$names[ ] = $user;
135 135
 			$text .= "{{Breve|admin|{{subst:#time:j}}|[[Utente:$user|]] " .
136 136
 				"non è stato riconfermato [[WP:A|amministratore]].}}\n";
137 137
 		}
@@ -165,16 +165,16 @@  discard block
 block discarded – undo
165 165
 	 *
166 166
 	 * @param PageRiconferma[] $pages
167 167
 	 */
168
-	protected function updateUltimeNotizie( array $pages ) {
168
+	protected function updateUltimeNotizie ( array $pages ) {
169 169
 		$this->getLogger()->info( 'Updating ultime notizie' );
170 170
 		$notiziePage = new Page( $this->getConfig()->get( 'ultimenotizie-page-title' ) );
171 171
 
172
-		$names = [];
172
+		$names = [ ];
173 173
 		$text = '';
174 174
 		foreach ( $pages as $page ) {
175 175
 			$user = $page->getUser();
176 176
 			$title = $page->getTitle();
177
-			$names[] = $user;
177
+			$names[ ] = $user;
178 178
 			$text .= "'''{{subst:#time:j F}}''': [[Utente:$user|]] non è stato [[$title|riconfermato]] " .
179 179
 				'[[WP:A|amministratore]]; ora gli admin sono {{subst:#expr: {{NUMBEROFADMINS}} - 1}}.';
180 180
 		}
Please login to merge, or discard this patch.
includes/Config.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -12,12 +12,12 @@  discard block
 block discarded – undo
12 12
 	/** @var self */
13 13
 	private static $instance;
14 14
 	/** @var array */
15
-	private $opts = [];
15
+	private $opts = [ ];
16 16
 
17 17
 	/**
18 18
 	 * Use self::init() and self::getInstance()
19 19
 	 */
20
-	private function __construct() {
20
+	private function __construct () {
21 21
 	}
22 22
 
23 23
 	/**
@@ -26,16 +26,16 @@  discard block
 block discarded – undo
26 26
 	 * @param array $defaults
27 27
 	 * @throws ConfigException
28 28
 	 */
29
-	public static function init( array $defaults ) {
29
+	public static function init ( array $defaults ) {
30 30
 		if ( self::$instance ) {
31 31
 			throw new ConfigException( 'Config was already initialized' );
32 32
 		}
33 33
 
34 34
 		$inst = new self;
35
-		$inst->set( 'list-title', $defaults['list-title'] );
36
-		$inst->set( 'msg-title', $defaults['msg-title'] );
37
-		$inst->set( 'username', $defaults['username'] );
38
-		$inst->set( 'password', $defaults['password'] );
35
+		$inst->set( 'list-title', $defaults[ 'list-title' ] );
36
+		$inst->set( 'msg-title', $defaults[ 'msg-title' ] );
37
+		$inst->set( 'username', $defaults[ 'username' ] );
38
+		$inst->set( 'password', $defaults[ 'password' ] );
39 39
 		self::$instance = $inst;
40 40
 
41 41
 		// On-wiki values
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 	 * @param string $key
55 55
 	 * @return string
56 56
 	 */
57
-	public function getWikiMessage( string $key ) : string {
57
+	public function getWikiMessage ( string $key ) : string {
58 58
 		static $messages = null;
59 59
 		if ( $messages === null ) {
60 60
 			try {
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 		if ( !isset( $messages[ $key ] ) ) {
68 68
 			throw new ConfigException( "Message '$key' does not exist." );
69 69
 		}
70
-		return $messages[$key];
70
+		return $messages[ $key ];
71 71
 	}
72 72
 	/**
73 73
 	 * Set a config value.
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	 * @param string $key
76 76
 	 * @param mixed $value
77 77
 	 */
78
-	protected function set( string $key, $value ) {
78
+	protected function set ( string $key, $value ) {
79 79
 		$this->opts[ $key ] = $value;
80 80
 	}
81 81
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	 * @return self
86 86
 	 * @throws ConfigException
87 87
 	 */
88
-	public static function getInstance() : self {
88
+	public static function getInstance () : self {
89 89
 		if ( !self::$instance ) {
90 90
 			throw new ConfigException( 'Config not yet initialized' );
91 91
 		}
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 	 * @return mixed
100 100
 	 * @throws ConfigException
101 101
 	 */
102
-	public function get( string $opt ) {
102
+	public function get ( string $opt ) {
103 103
 		if ( !isset( $this->opts[ $opt ] ) ) {
104 104
 			throw new ConfigException( "Config option '$opt' not set." );
105 105
 		}
Please login to merge, or discard this patch.
includes/TaskDataProvider.php 1 patch
Spacing   +20 added lines, -22 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -15,14 +15,14 @@  discard block
 block discarded – undo
15 15
 	/** @var array[] */
16 16
 	private $allUsers;
17 17
 	/** @var PageRiconferma[] */
18
-	private $createdPages = [];
18
+	private $createdPages = [ ];
19 19
 
20 20
 	/**
21 21
 	 * Get the full content of the JSON users list
22 22
 	 *
23 23
 	 * @return array[]
24 24
 	 */
25
-	public function getUsersList() : array {
25
+	public function getUsersList () : array {
26 26
 		if ( $this->allUsers === null ) {
27 27
 			$this->getLogger()->debug( 'Retrieving users list' );
28 28
 			$this->allUsers = PageBotList::get()->getAdminsList();
@@ -36,9 +36,9 @@  discard block
 block discarded – undo
36 36
 	 *
37 37
 	 * @return array[]
38 38
 	 */
39
-	public function getUsersToProcess() : array {
39
+	public function getUsersToProcess () : array {
40 40
 		if ( $this->processUsers === null ) {
41
-			$this->processUsers = [];
41
+			$this->processUsers = [ ];
42 42
 			foreach ( $this->getUsersList() as $user => $groups ) {
43 43
 				$timestamp = $this->getValidTimestamp( $groups );
44 44
 
@@ -60,17 +60,15 @@  discard block
 block discarded – undo
60 60
 	 * @param array $groups
61 61
 	 * @return int
62 62
 	 */
63
-	private function getValidTimestamp( array $groups ) : int {
64
-		if ( isset( $groups['override'] ) ) {
65
-			return $groups['override'];
63
+	private function getValidTimestamp ( array $groups ) : int {
64
+		if ( isset( $groups[ 'override' ] ) ) {
65
+			return $groups[ 'override' ];
66 66
 		}
67 67
 
68 68
 		$checkuser = isset( $groups[ 'checkuser' ] ) ?
69
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() :
70
-			0;
69
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() : 0;
71 70
 		$bureaucrat = isset( $groups[ 'bureaucrat' ] ) ?
72
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() :
73
-			0;
71
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() : 0;
74 72
 
75 73
 		$timestamp = max( $bureaucrat, $checkuser );
76 74
 		if ( $timestamp === 0 ) {
@@ -84,7 +82,7 @@  discard block
 block discarded – undo
84 82
 	 *
85 83
 	 * @return PageRiconferma[]
86 84
 	 */
87
-	public function getOpenPages() : array {
85
+	public function getOpenPages () : array {
88 86
 		static $list = null;
89 87
 		if ( $list === null ) {
90 88
 			$baseTitle = $this->getConfig()->get( 'main-page-title' );
@@ -98,10 +96,10 @@  discard block
 block discarded – undo
98 96
 
99 97
 			$res = RequestBase::newFromParams( $params )->execute();
100 98
 			$pages = $res->query->pages;
101
-			$list = [];
99
+			$list = [ ];
102 100
 			foreach ( reset( $pages )->templates as $page ) {
103 101
 				if ( preg_match( "!$baseTitle\/[^\/]+\/\d!", $page->title ) !== false ) {
104
-					$list[] = new PageRiconferma( $page->title );
102
+					$list[ ] = new PageRiconferma( $page->title );
105 103
 				}
106 104
 			}
107 105
 		}
@@ -114,14 +112,14 @@  discard block
 block discarded – undo
114 112
 	 *
115 113
 	 * @return PageRiconferma[]
116 114
 	 */
117
-	public function getPagesToClose() : array {
115
+	public function getPagesToClose () : array {
118 116
 		static $list = null;
119 117
 		if ( $list === null ) {
120 118
 			$allPages = $this->getOpenPages();
121
-			$list = [];
119
+			$list = [ ];
122 120
 			foreach ( $allPages as $page ) {
123 121
 				if ( time() > $page->getEndTimestamp() ) {
124
-					$list[] = $page;
122
+					$list[ ] = $page;
125 123
 				}
126 124
 			}
127 125
 		}
@@ -133,21 +131,21 @@  discard block
 block discarded – undo
133 131
 	 *
134 132
 	 * @param string $name
135 133
 	 */
136
-	public function removeUser( string $name ) {
134
+	public function removeUser ( string $name ) {
137 135
 		unset( $this->processUsers[ $name ] );
138 136
 	}
139 137
 
140 138
 	/**
141 139
 	 * @return PageRiconferma[]
142 140
 	 */
143
-	public function getCreatedPages() : array {
141
+	public function getCreatedPages () : array {
144 142
 		return $this->createdPages;
145 143
 	}
146 144
 
147 145
 	/**
148 146
 	 * @param PageRiconferma $page
149 147
 	 */
150
-	public function addCreatedPages( PageRiconferma $page ) {
151
-		$this->createdPages[] = $page;
148
+	public function addCreatedPages ( PageRiconferma $page ) {
149
+		$this->createdPages[ ] = $page;
152 150
 	}
153 151
 }
Please login to merge, or discard this patch.
includes/Message.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 	/**
15 15
 	 * @param string $key
16 16
 	 */
17
-	public function __construct( string $key ) {
17
+	public function __construct ( string $key ) {
18 18
 		$this->key = $key;
19 19
 		$this->value = Config::getInstance()->getWikiMessage( $key );
20 20
 	}
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 	 * @param array $args
24 24
 	 * @return self
25 25
 	 */
26
-	public function params( array $args ) : self {
26
+	public function params ( array $args ) : self {
27 27
 		$this->value = strtr( $this->value, $args );
28 28
 		return $this;
29 29
 	}
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 	/**
32 32
 	 * @return string
33 33
 	 */
34
-	public function text() : string {
34
+	public function text () : string {
35 35
 		$this->parsePlurals();
36 36
 		return $this->value;
37 37
 	}
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	/**
40 40
 	 * Replace {{$plur|<amount>|sing|plur}}
41 41
 	 */
42
-	protected function parsePlurals() {
42
+	protected function parsePlurals () {
43 43
 		$reg = '!\{\{$plur|(?P<amount>\d+)|(?P<sing>[^}|]+)|(?P<plur>[^|}]+)}}!';
44 44
 
45 45
 		if ( preg_match( $reg, $this->value ) === false ) {
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 		$this->value = preg_replace_callback(
49 49
 			$reg,
50 50
 			function ( $matches ) {
51
-				return intval( $matches['amount'] ) > 1 ? trim( $matches['plur'] ) : trim( $matches['sing'] );
51
+				return intval( $matches[ 'amount' ] ) > 1 ? trim( $matches[ 'plur' ] ) : trim( $matches[ 'sing' ] );
52 52
 			},
53 53
 			$this->value
54 54
 		);
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 	 * @param int $timestamp
61 61
 	 * @return string
62 62
 	 */
63
-	public static function getTimeWithArticle( int $timestamp ) : string {
63
+	public static function getTimeWithArticle ( int $timestamp ) : string {
64 64
 		$oldLoc = setlocale( LC_TIME, 'it_IT', 'Italian_Italy', 'Italian' );
65 65
 		$timeString = strftime( '%e %B alle %R', $timestamp );
66 66
 		// Remove the left space if day has a single digit
@@ -78,16 +78,16 @@  discard block
 block discarded – undo
78 78
 	 * @return int
79 79
 	 * @todo Is there a better way?
80 80
 	 */
81
-	public static function getTimestampFromLocalTime( string $timeString ) : int {
81
+	public static function getTimestampFromLocalTime ( string $timeString ) : int {
82 82
 		$oldLoc = setlocale( LC_TIME, 'it_IT', 'Italian_Italy', 'Italian' );
83 83
 		$bits = strptime( $timeString, '%e %m %Y alle %H:%M' );
84 84
 		$timestamp = mktime(
85
-			$bits['tm_hour'],
86
-			$bits['tm_min'],
85
+			$bits[ 'tm_hour' ],
86
+			$bits[ 'tm_min' ],
87 87
 			0,
88
-			$bits['tm_mon'] + 1,
89
-			$bits['tm_mday'],
90
-			$bits['tm_year'] + 1900
88
+			$bits[ 'tm_mon' ] + 1,
89
+			$bits[ 'tm_mday' ],
90
+			$bits[ 'tm_year' ] + 1900
91 91
 		);
92 92
 		setlocale( LC_TIME, $oldLoc );
93 93
 
@@ -102,12 +102,12 @@  discard block
 block discarded – undo
102 102
 	 * @param string $emptyText
103 103
 	 * @return string
104 104
 	 */
105
-	public static function commaList( array $data, string $emptyText = 'nessuno' ) : string {
105
+	public static function commaList ( array $data, string $emptyText = 'nessuno' ) : string {
106 106
 		if ( count( $data ) > 1 ) {
107 107
 			$last = array_pop( $data );
108 108
 			$ret = implode( ', ', $data ) . " e $last";
109 109
 		} elseif ( $data ) {
110
-			$ret = $data[0];
110
+			$ret = $data[ 0 ];
111 111
 		} else {
112 112
 			$ret = $emptyText;
113 113
 		}
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 		return $ret;
116 116
 	}
117 117
 
118
-	public function __toString() {
118
+	public function __toString () {
119 119
 		return $this->text();
120 120
 	}
121 121
 }
Please login to merge, or discard this patch.
includes/Task/UpdateList.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task;
4 4
 
@@ -19,15 +19,15 @@  discard block
 block discarded – undo
19 19
 	/**
20 20
 	 * @inheritDoc
21 21
 	 */
22
-	protected function getSubtasksMap(): array {
22
+	protected function getSubtasksMap (): array {
23 23
 		// Everything is done here.
24
-		return [];
24
+		return [ ];
25 25
 	}
26 26
 
27 27
 	/**
28 28
 	 * @inheritDoc
29 29
 	 */
30
-	public function runInternal() : int {
30
+	public function runInternal () : int {
31 31
 		$this->actualList = $this->getActualAdmins();
32 32
 		$this->botList = $this->getDataProvider()->getUsersList();
33 33
 
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 	/**
57 57
 	 * @return array
58 58
 	 */
59
-	protected function getActualAdmins() : array {
59
+	protected function getActualAdmins () : array {
60 60
 		$this->getLogger()->debug( 'Retrieving admins - API' );
61 61
 		$params = [
62 62
 			'action' => 'query',
@@ -74,8 +74,8 @@  discard block
 block discarded – undo
74 74
 	 * @param \stdClass $data
75 75
 	 * @return array
76 76
 	 */
77
-	protected function extractAdmins( \stdClass $data ) : array {
78
-		$ret = [];
77
+	protected function extractAdmins ( \stdClass $data ) : array {
78
+		$ret = [ ];
79 79
 		$blacklist = $this->getConfig()->get( 'exclude-admins' );
80 80
 		foreach ( $data->query->allusers as $u ) {
81 81
 			if ( in_array( $u->name, $blacklist ) ) {
@@ -92,22 +92,22 @@  discard block
 block discarded – undo
92 92
 	 *
93 93
 	 * @return array[]
94 94
 	 */
95
-	protected function getMissingGroups() : array {
96
-		$missing = [];
95
+	protected function getMissingGroups () : array {
96
+		$missing = [ ];
97 97
 		foreach ( $this->actualList as $adm => $groups ) {
98
-			$groupsList = [];
98
+			$groupsList = [ ];
99 99
 			if ( !isset( $this->botList[ $adm ] ) ) {
100 100
 				$groupsList = $groups;
101
-			} elseif ( count( $groups ) > count( $this->botList[$adm] ) ) {
101
+			} elseif ( count( $groups ) > count( $this->botList[ $adm ] ) ) {
102 102
 				// Only some groups are missing
103
-				$groupsList = array_diff_key( $groups, $this->botList[$adm] );
103
+				$groupsList = array_diff_key( $groups, $this->botList[ $adm ] );
104 104
 			}
105 105
 
106 106
 			foreach ( $groupsList as $group ) {
107 107
 				try {
108 108
 					$missing[ $adm ][ $group ] = $this->getFlagDate( $adm, $group );
109 109
 				} catch ( TaskException $e ) {
110
-					$this->errors[] = $e->getMessage();
110
+					$this->errors[ ] = $e->getMessage();
111 111
 				}
112 112
 			}
113 113
 		}
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	 * @return string
123 123
 	 * @throws TaskException
124 124
 	 */
125
-	protected function getFlagDate( string $admin, string $group ) : string {
125
+	protected function getFlagDate ( string $admin, string $group ) : string {
126 126
 		$this->getLogger()->info( "Retrieving $group flag date for $admin" );
127 127
 
128 128
 		$url = DEFAULT_URL;
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 	 * @param string $group
158 158
 	 * @return string|null
159 159
 	 */
160
-	private function extractTimestamp( \stdClass $data, string $group ) : ?string {
160
+	private function extractTimestamp ( \stdClass $data, string $group ) : ?string {
161 161
 		$ts = null;
162 162
 		foreach ( $data->query->logevents as $entry ) {
163 163
 			if ( !isset( $entry->params ) ) {
@@ -179,8 +179,8 @@  discard block
 block discarded – undo
179 179
 	 *
180 180
 	 * @return array[]
181 181
 	 */
182
-	protected function getExtraGroups() : array {
183
-		$extra = [];
182
+	protected function getExtraGroups () : array {
183
+		$extra = [ ];
184 184
 		foreach ( $this->botList as $name => $groups ) {
185 185
 			$trueGroups = array_diff_key( $groups, [ 'override' => true ] );
186 186
 			if ( !isset( $this->actualList[ $name ] ) ) {
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 	 * @param array[] $extra
200 200
 	 * @return array[]
201 201
 	 */
202
-	protected function getNewContent( array $missing, array $extra ) : array {
202
+	protected function getNewContent ( array $missing, array $extra ) : array {
203 203
 		$newContent = $this->botList;
204 204
 		foreach ( $newContent as $user => $groups ) {
205 205
 			if ( isset( $missing[ $user ] ) ) {
Please login to merge, or discard this patch.