Renderable_choice::editableRadio() - Code Metrics - Inspection of "choice datatype, renderable" - Corollarium/Formularium - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d764eb...5a8560 )

by Bruno

created 2019-12-11 20:49 UTC

Renderable_choice::editableRadio() B

↳ Parent: Renderable_choice

Complexity

Conditions	9
Paths	26

Size

Total Lines	54
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	90

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	9
eloc	31
c	1
b	0
f	0
nc	26
nop	3
dl	0
loc	54
ccs	0
cts	45
cp	0
crap	90
rs	8.0555

How to fix Long Method

<?php

namespace Formularium\Frontend\HTML\Renderable;

use Formularium\Datatype;
use Formularium\Datatype\Datatype_choice;
use Formularium\Field;
use Formularium\Frontend\HTML\Framework;
use Formularium\Frontend\HTML\Renderable;
use Formularium\HTMLElement;

class Renderable_choice extends Renderable
{
    public const FORMAT_CHOOSER = 'format_chooser';
    public const FORMAT_CHOOSER_SELECT = 'format_chooser_select';
    public const FORMAT_CHOOSER_RADIO = 'format_chooser_radio';
    public const LAYOUT_RADIO = 'inline';
    public const LAYOUT_RADIO_INLINE = 'inline';

    use \Formularium\Frontend\HTML\RenderableViewableTrait {
        viewable as _viewable;
    }
    
    public function viewable($value, Field $field, HTMLElement $previous): HTMLElement
    {
        $formatted = $field->getDatatype()->format($value, $field);

        return $this->_viewable($formatted, $field, $previous);
    }

    public function editable($value, Field $field, HTMLElement $previous): HTMLElement
    {
        $format = $field->getExtension(static::FORMAT_CHOOSER, static::FORMAT_CHOOSER_SELECT);
        
        if ($format == static::FORMAT_CHOOSER_SELECT) {
            $element = $this->editableSelect($value, $field, $previous);
        } else {
            $element = $this->editableRadio($value, $field, $previous);
        }

        return $this->container($element, $field);
    }

    /**
     * @param mixed $value
     * @param Field $field
     * @param HTMLElement $previous
     * @return HTMLElement
     */
    protected function editableRadio($value, Field $field, HTMLElement $previous): HTMLElement
    protected function editableRadio($value, Field $field, /** @scrutinizer ignore-unused */ HTMLElement $previous): HTMLElement
    {
        if (empty($value) && array_key_exists(static::DEFAULTVALUE, $field->getExtensions())) {
            $value = $field->getExtensions()[static::DEFAULTVALUE];
        }

        $element = new HTMLElement('div', ['class' => 'formularium-radio-group']);

        $idcounter = 1;

        /**
         * @var Datatype_choice $field
         */
        $datatype = $field->getDatatype();
        $datatype = $field->getDatatype();
        foreach ($datatype->getChoices() as $v => $label) {
            $input = new HTMLElement('input');

            // send ids to delete/edit data later correctly.
            if ($value !== null && $v == $value) {
                $input->addAttribute('checked', 'checked');
            }
            $elementname = $field->getName(); // 'loh:' . $this->name . '[' . $attrid . '][value]' . '[' . $attrid . ']';
            $id = $field->getName() . Framework::counter();
            $input->addAttributes([
                'id' => $id,
                'name' => $elementname,
                'data-attribute' => $field->getName(),
                'data-datatype' => $datatype->getName(),
                'data-basetype' => $datatype->getBasetype(),
                'value' => $value,
                'type' => 'radio'
            ]);

            if ($field->getValidators()[Datatype::REQUIRED] ?? false) {
            if ($field->/** @scrutinizer ignore-call */ getValidators()[Datatype::REQUIRED] ?? false) {
                $element->setAttribute('required', 'required');
            }
            foreach ([static::DISABLED, static::READONLY] as $p) {
                if ($field->getExtension($p, false)) {
                if ($field->/** @scrutinizer ignore-call */ getExtension($p, false)) {
                    $input->setAttribute($p, $p);
                }
            }
    
            $li = new HTMLElement(
                'div',
                [
                    'class' => 'formularium-radio-item'
                ],
                [
                    $input,
                    new HTMLElement('label', ['class' => 'formularium-radio-label', 'for' => $id], [$label])
                ]
            );
            $element->addContent($li);
        }
        return $element;
    }

    /**
     * @param mixed $value
     * @param Field $field
     * @param HTMLElement $previous
     * @return HTMLElement
     */
    protected function editableSelect($value, Field $field, HTMLElement $previous): HTMLElement
    protected function editableSelect($value, Field $field, /** @scrutinizer ignore-unused */ HTMLElement $previous): HTMLElement
    {
        $element = new HTMLElement('select');
        $element->setAttributes([
            'id' => $field->getName() . Framework::counter(),
            'name' => $field->getName(),
            'class' => '',
            'data-attribute' => $field->getName(),
            'data-datatype' => $field->getDatatype()->getName(),
            'data-basetype' => $field->getDatatype()->getBasetype(),
            'title' => $field->getExtension(static::LABEL, '')
        ]);

        $optionEmpty = new HTMLElement('option', ['value' => ''], '', true);

        /**
         * @var Datatype_choice $field
         */
        $datatype = $field->getDatatype();

        if ($field->getValidators()[Datatype::REQUIRED] ?? false) {
            $optionEmpty = new HTMLElement('option', ['value' => ''], '', true);
            $element->addContent($optionEmpty);
        }

        foreach ($datatype->getChoices() as $v => $label) {
            $option = new HTMLElement('option', ['value' => $v], $label, true);

            if ($value == $v) {
                $option->setAttribute('selected', 'selected');
            }
            $element->addContent($option);
        }

        foreach ([static::DISABLED, static::READONLY] as $v) {
            if ($field->getExtension($v, false)) {
                $element->setAttribute($v, $v);
            }
        }

        return $element;
    }
}


Corollarium / Formularium

Push — master ( d764eb...5a8560 )

Renderable_choice::editableRadio() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like