alert.js ➔ ... ➔ Modal.extend.confirm - Code Metrics - Inspection of "Revamp UI (#179)" - SolidInvoice/SolidInvoice - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d3ad00...acd091 )

by Pierre

created 2017-07-16 10:42 UTC

alert.js ➔ ... ➔ Modal.extend.confirm B

↳ Parent: alert.js ➔ ... ➔ .confirm

Complexity

Conditions	5
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
nc	3
nop	0
dl	0
loc	20
rs	8.8571
c	0
b	0
f	0

'use strict';


define(['jquery', 'marionette', 'lodash', 'core/modal'], function($, Mn, _, Modal) {

    return {
        alert: function(message) {
            let m = Modal.extend({

                'template': message,
                'modal': {
                    'buttons': {
                        'Close': {
                            'close': true,
                            'class': 'info',
                            'flat': true
                        },
                    }
                }
            });

            let v = new m();


            v.render();

            return v;
        },
        confirm: function(message, callback) {
            let m = Modal.extend({

                'template': message,
                'modal': {
                    'buttons': {
                        'Cancel': {
                            'close': true,
                            'class': 'warning',
                            'flat': true
                        },
                        'OK': {
                            'class': 'success',
                            'flat': true,
                            'save': true
                        }
                    },
                    'events': {
                        'modal:save': 'confirm'
                    }
                },
                confirm: function() {
                    this.showLoader();

                    let close = _.bind(function() {

                        this.$el.modal('hide');
                        this.hideLoader();
                    }, this);

                    if (_.isFunction(callback)) {
                        let response = callback.call(this, true);


                        if (response instanceof Promise || response instanceof $.Deferred || _.result(response, 'then')) {

                            response.then(close);
                        } else {
                            close.apply(this)

                        }
                    } else {
                        close.apply(this);
                    }
                }
            });

            let v = new m();


            v.render();

            return v;
        }
    };
});

1			'use strict';
			0 ignored issues – show Coding Style introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report Use the function form of "use strict". Loading history...
2
3			define(['jquery', 'marionette', 'lodash', 'core/modal'], function($, Mn, _, Modal) {
			0 ignored issues – show Bug introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report `define` does not seem to be defined. Loading history...
4			return {
5			alert: function(message) {
6			let m = Modal.extend({
			0 ignored issues – show Backwards Compatibility introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report 'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz). Loading history...
7			'template': message,
8			'modal': {
9			'buttons': {
10			'Close': {
11			'close': true,
12			'class': 'info',
13			'flat': true
14			},
15			}
16			}
17			});
18
19			let v = new m();
			0 ignored issues – show Coding Style Best Practice introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report By convention, constructors like `m` should be capitalized. Loading history... Backwards Compatibility introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report 'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz). Loading history...
20
21			v.render();
22
23			return v;
24			},
25			confirm: function(message, callback) {
26			let m = Modal.extend({
			0 ignored issues – show Backwards Compatibility introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report 'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz). Loading history...
27			'template': message,
28			'modal': {
29			'buttons': {
30			'Cancel': {
31			'close': true,
32			'class': 'warning',
33			'flat': true
34			},
35			'OK': {
36			'class': 'success',
37			'flat': true,
38			'save': true
39			}
40			},
41			'events': {
42			'modal:save': 'confirm'
43			}
44			},
45			confirm: function() {
46			this.showLoader();
47
48			let close = _.bind(function() {
			0 ignored issues – show Backwards Compatibility introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report 'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz). Loading history...
49			this.$el.modal('hide');
50			this.hideLoader();
51			}, this);
52
53			if (_.isFunction(callback)) {
54			let response = callback.call(this, true);
			0 ignored issues – show Backwards Compatibility introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report 'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz). Loading history...
55
56			if (response instanceof Promise \|\| response instanceof $.Deferred \|\| _.result(response, 'then')) {
			0 ignored issues – show Bug introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report `Promise` does not seem to be defined. Loading history...
57			response.then(close);
58			} else {
59			close.apply(this)
			0 ignored issues – show Coding Style introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
60			}
61			} else {
62			close.apply(this);
63			}
64			}
65			});
66
67			let v = new m();
			0 ignored issues – show Coding Style Best Practice introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report By convention, constructors like `m` should be capitalized. Loading history... Backwards Compatibility introduced 2017-07-10 14:30 UTC by Report Bug Copy Issue Report 'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz). Loading history...
68
69			v.render();
70
71			return v;
72			}
73			};
74			});

SolidInvoice / SolidInvoice

Scrutinizer GitHub App not installed

Push — master ( d3ad00...acd091 )

alert.js ➔ ... ➔ Modal.extend.confirm B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like