BOINC / boinc

sched/transitioner_catchup.php

Braces +3 added lines, -1 removed lines

@@ -28,7 +28,9 @@
     while (1) {
         $now = time();
         $wus = BoincWorkunit::enum("transition_time<$now limit 1");
-        if (count($wus) == 0) break;
+        if (count($wus) == 0) {
+            break;
+        }
         echo "Some WUs need transition - running transitioner.\n";
         $ret = system("bin/transitioner --one_pass");
         echo "ret: $ret\n";

doc/help_lang.php

Braces +23 added lines, -11 removed lines

@@ -45,17 +45,29 @@
         return "<font size=-2>(no ratings)</font>";
     }
     $x = $vol->rating_sum/$vol->nratings;
-    if ($x > 4.5) $img = "stars-5-0.gif";
-    else if ($x > 4.0) $img = "stars-4-5.gif";
-    else if ($x > 3.5) $img = "stars-4-0.gif";
-    else if ($x > 3.0) $img = "stars-3-5.gif";
-    else if ($x > 2.5) $img = "stars-3-0.gif";
-    else if ($x > 2.0) $img = "stars-2-5.gif";
-    else if ($x > 1.5) $img = "stars-2-0.gif";
-    else if ($x > 1.0) $img = "stars-1-5.gif";
-    else if ($x > 0.5) $img = "stars-1-0.gif";
-    else if ($x > 0.0) $img = "stars-0-5.gif";
-    else $img = "stars-0-0.gif";
+    if ($x > 4.5) {
+        $img = "stars-5-0.gif";
+    } else if ($x > 4.0) {
+        $img = "stars-4-5.gif";
+    } else if ($x > 3.5) {
+        $img = "stars-4-0.gif";
+    } else if ($x > 3.0) {
+        $img = "stars-3-5.gif";
+    } else if ($x > 2.5) {
+        $img = "stars-3-0.gif";
+    } else if ($x > 2.0) {
+        $img = "stars-2-5.gif";
+    } else if ($x > 1.5) {
+        $img = "stars-2-0.gif";
+    } else if ($x > 1.0) {
+        $img = "stars-1-5.gif";
+    } else if ($x > 0.5) {
+        $img = "stars-1-0.gif";
+    } else if ($x > 0.0) {
+        $img = "stars-0-5.gif";
+    } else {
+        $img = "stars-0-0.gif";
+    }
     return "
         <nobr><a href=help_ratings.php?volid=$vol->id>
         <img border=0 src=images/help/$img>

doc/sim/sim_web.php

Braces +30 added lines, -10 removed lines

@@ -30,13 +30,21 @@ 
 
 function get_comments($dir) {
     $d = "$dir/comments";
-    if (!is_dir($d)) return null;
+    if (!is_dir($d)) {
+        return null;
+    }
     $dd = opendir($d);
     $x = "";
     while (false !== ($f = readdir($dd))) {
-        if ($f == ".") continue;
-        if ($f == "..") continue;
-        if (strlen($x)) $x .= "<hr>\n";
+        if ($f == ".") {
+            continue;
+        }
+        if ($f == "..") {
+            continue;
+        }
+        if (strlen($x)) {
+            $x .= "<hr>\n";
+        }
         $userid = (int)file_get_contents("$d/$f/userid");
         $user = BoincUser::lookup_id($userid);
         $comment = file_get_contents("$d/$f/comment");
@@ -50,8 +58,12 @@ 
     $d = opendir("scenarios/$scen/simulations");
     $n = 0;
     while (false !== ($f = readdir($d))) {
-        if ($f == ".") continue;
-        if ($f == "..") continue;
+        if ($f == ".") {
+            continue;
+        }
+        if ($f == "..") {
+            continue;
+        }
         $n++;
     }
     return $n;
@@ -174,8 +186,12 @@ 
     $d = opendir("scenarios");
     $dirs = array();
     while (false !== ($f = readdir($d))) {
-        if ($f === ".") continue;
-        if ($f === "..") continue;
+        if ($f === ".") {
+            continue;
+        }
+        if ($f === "..") {
+            continue;
+        }
         $dirs[] = $f;
     }
     rsort($dirs);
@@ -338,7 +354,9 @@ 
     $dirs = array();
     $s = opendir("$d/simulations");
     while (false !== ($f = readdir($s))) {
-        if (!is_numeric($f)) continue;
+        if (!is_numeric($f)) {
+            continue;
+        }
         $dirs[] = $f;
     }
     rsort($dirs);
@@ -515,7 +533,9 @@ 
 }
 
 $action = get_str("action", true);
-if (!$action) $action = post_str("action", true);
+if (!$action) {
+    $action = post_str("action", true);
+}
 
 switch ($action) {
 case "create_scenario_form":

doc/sim/sim_util.inc

Braces +15 added lines, -5 removed lines

@@ -76,10 +76,18 @@ 
 //
 function do_sim($in, $out, $policy) {
     $args = "";
-    if ($policy->existing_jobs_only) $args .= " --existing_jobs_only";
-    if ($policy->cpu_sched_rr_only) $args .= " --cpu_sched_rr_only";
-    if ($policy->include_empty_projects) $args .= " --include_empty_projects";
-    if ($policy->server_uses_workload) $args .= " --server_uses_workload";
+    if ($policy->existing_jobs_only) {
+        $args .= " --existing_jobs_only";
+    }
+    if ($policy->cpu_sched_rr_only) {
+        $args .= " --cpu_sched_rr_only";
+    }
+    if ($policy->include_empty_projects) {
+        $args .= " --include_empty_projects";
+    }
+    if ($policy->server_uses_workload) {
+        $args .= " --server_uses_workload";
+    }
     $args .= " --duration $policy->duration";
     $args .= " --delta $policy->delta";
     $args .= " --rec_half_life $policy->rec_half_life";
@@ -221,7 +229,9 @@ 
     $cs_template_fname = "$scenario/client_state_template.xml";
     $cs_fname = "$scenario/client_state.xml";
     $cs = file_get_contents($cs_template_fname);
-    if (!$cs) die("no file $cs_template_fname");
+    if (!$cs) {
+        die("no file $cs_template_fname");
+    }
     $cs = str_replace("PARAM", $param, $cs);
     file_put_contents($cs_fname, $cs);
     do_sim($scenario, $sim_out_dir, $policy);

doc/help_db.php

Braces +9 added lines, -3 removed lines

@@ -111,7 +111,9 @@ 
 
 function vol_lookup($id) {
     $result = mysql_query("select * from volunteer where id=$id");
-    if (!$result) return null;
+    if (!$result) {
+        return null;
+    }
     $vol = mysql_fetch_object($result);
     mysql_free_result($result);
     return $vol;
@@ -120,7 +122,9 @@ 
 function vol_lookup_email($email) {
     $email = mysql_real_escape_string($email);
     $result = mysql_query("select * from volunteer where email_addr='$email'");
-    if (!$result) return null;
+    if (!$result) {
+        return null;
+    }
     $vol = mysql_fetch_object($result);
     mysql_free_result($result);
     return $vol;
@@ -129,7 +133,9 @@ 
 function vol_lookup_name($name) {
     $name = mysql_real_escape_string($name);
     $result = mysql_query("select * from volunteer where name='$name'");
-    if (!$result) return null;
+    if (!$result) {
+        return null;
+    }
     $vol = mysql_fetch_object($result);
     mysql_free_result($result);
     return $vol;

doc/get_platforms.inc

Braces +90 added lines, -32 removed lines

@@ -13,8 +13,12 @@ 
         $pc = substr($x[1], 0, -1);
     }
 
-    if (strstr($p, "fubar")) return null;
-    if ($p == 'x86_64-unknown-linux-gnu') return null;
+    if (strstr($p, "fubar")) {
+        return null;
+    }
+    if ($p == 'x86_64-unknown-linux-gnu') {
+        return null;
+    }
     $q = $p;
     switch ($p) {
     case 'i686-pc-linux-gnu': $q = 'Linux/x86'; break;
@@ -39,13 +43,21 @@ 
     case 'arm-unknown-linux-gnueabihf': $q = 'Linux on ARM (e.g., Raspberry Pi)';
     }
     if (strlen($pc)) {
-        if (strstr($pc, 'cuda')) $q .= " (NVIDIA GPU)";
-        else if (strstr($pc, 'nvidia')) $q .= " (NVIDIA GPU)";
-        else if (strstr($pc, 'ati')) $q .= " (AMD/ATI GPU)";
-        else if (strstr($pc, 'intel_gpu')) $q .= " (Intel GPU)";
-        else if (strstr($pc, 'mt')) $q .= " (multicore)";
-        else if (strstr($pc, 'vbox32')) $q .= " (VirtualBox 32-bit)";
-        else if (strstr($pc, 'vbox64')) $q .= " (VirtualBox 64-bit)";
+        if (strstr($pc, 'cuda')) {
+            $q .= " (NVIDIA GPU)";
+        } else if (strstr($pc, 'nvidia')) {
+            $q .= " (NVIDIA GPU)";
+        } else if (strstr($pc, 'ati')) {
+            $q .= " (AMD/ATI GPU)";
+        } else if (strstr($pc, 'intel_gpu')) {
+            $q .= " (Intel GPU)";
+        } else if (strstr($pc, 'mt')) {
+            $q .= " (multicore)";
+        } else if (strstr($pc, 'vbox32')) {
+            $q .= " (VirtualBox 32-bit)";
+        } else if (strstr($pc, 'vbox64')) {
+            $q .= " (VirtualBox 64-bit)";
+        }
     }
     return $q;
 }
@@ -71,19 +83,45 @@ 
             $p = $y[0];
             $pc = substr($y[1], 0, -1);
         }
-        if (strstr($p, "windows")) $x->windows = true;
-        if (strstr($p, "darwin")) $x->mac = true;
-        if (strstr($p, "linux")) $x->linux = true;
-        if (strstr($p, "android")) $x->android = true;
-        if (strstr($p, "freebsd")) $x->freebsd = true;
-        if (strstr($p, "arm-unknown-linux-gnueabihf")) $x->rasp_pi = true;
-        if (strstr($p, "armv5")) $x->rasp_pi = true;
-        if (strstr($p, "armv6")) $x->rasp_pi = true;
-        if (strstr($pc, "ati")) $x->amd_gpu = true;
-        if (strstr($pc, "cuda")) $x->nvidia_gpu = true;
-        if (strstr($pc, "nvidia")) $x->nvidia_gpu = true;
-        if (strstr($pc, "intel_gpu")) $x->intel_gpu = true;
-        if (strstr($pc, "vbox")) $x->vbox = true;
+        if (strstr($p, "windows")) {
+            $x->windows = true;
+        }
+        if (strstr($p, "darwin")) {
+            $x->mac = true;
+        }
+        if (strstr($p, "linux")) {
+            $x->linux = true;
+        }
+        if (strstr($p, "android")) {
+            $x->android = true;
+        }
+        if (strstr($p, "freebsd")) {
+            $x->freebsd = true;
+        }
+        if (strstr($p, "arm-unknown-linux-gnueabihf")) {
+            $x->rasp_pi = true;
+        }
+        if (strstr($p, "armv5")) {
+            $x->rasp_pi = true;
+        }
+        if (strstr($p, "armv6")) {
+            $x->rasp_pi = true;
+        }
+        if (strstr($pc, "ati")) {
+            $x->amd_gpu = true;
+        }
+        if (strstr($pc, "cuda")) {
+            $x->nvidia_gpu = true;
+        }
+        if (strstr($pc, "nvidia")) {
+            $x->nvidia_gpu = true;
+        }
+        if (strstr($pc, "intel_gpu")) {
+            $x->intel_gpu = true;
+        }
+        if (strstr($pc, "vbox")) {
+            $x->vbox = true;
+        }
     }
     return $x;
 }
@@ -126,9 +164,15 @@ 
 }
 
 function canonical_plan_class($pc) {
-	if (strstr($pc, "atiOpenCL")) return "opencl_ati";
-	if (strstr($pc, "nvidiaOpenCL")) return "opencl_nvidia";
-	if (strstr($pc, "intelOpenCL")) return "opencl_intel_gpu";
+	if (strstr($pc, "atiOpenCL")) {
+	    return "opencl_ati";
+	}
+	if (strstr($pc, "nvidiaOpenCL")) {
+	    return "opencl_nvidia";
+	}
+	if (strstr($pc, "intelOpenCL")) {
+	    return "opencl_intel_gpu";
+	}
     return $pc;
 }
 
@@ -136,10 +180,16 @@ 
 //
 function valid($url, $plat) {
     if (strstr($url, "gpugrid.net")) {
-        if (strstr($plat, "android")) return false;
-        if (strstr($plat, "vbox")) return false;
+        if (strstr($plat, "android")) {
+            return false;
+        }
+        if (strstr($plat, "vbox")) {
+            return false;
+        }
     } else if (strstr($url, "csgrid")) {
-        if (strstr($plat, "android")) return false;
+        if (strstr($plat, "android")) {
+            return false;
+        }
     }
     return true;
 }
@@ -165,7 +215,9 @@ 
 //   ...
 //
 function get_platforms($url) {
-    if (strstr($url, "radioactive")) return null;
+    if (strstr($url, "radioactive")) {
+        return null;
+    }
     $url .= 'get_project_config.php';
     $x = @file_get_contents($url);
     if (!$x) {
@@ -230,7 +282,9 @@ 
     $list = null;
     foreach($s->application as $a) {
         foreach ($a->version as $v) {
-            if (!array_key_exists('platform_short', $v)) continue;
+            if (!array_key_exists('platform_short', $v)) {
+                continue;
+            }
             $p = $v->platform_short[0];
             $pc = "";
             if (array_key_exists('plan_class', $v)) {
@@ -250,11 +304,15 @@ 
 // list of human-readable names
 //
 function make_friendly_string($l, $comma) {
-    if (!count($l)) return "Unknown";
+    if (!count($l)) {
+        return "Unknown";
+    }
     $fn = array();
     foreach($l as $p) {
         $p = friendly_name($p);
-        if (!$p) continue;
+        if (!$p) {
+            continue;
+        }
         $fn[] = $p;
     }
     $fn = array_unique($fn);

doc/projects.php

Braces +3 added lines, -1 removed lines

@@ -60,7 +60,9 @@
     shuffle($areas);
     foreach ($areas as $area) {
         $title = $area[0];
-        if (sizeof($area)==3) $title .= $area[2];
+        if (sizeof($area)==3) {
+            $title .= $area[2];
+        }
         list_bar($title);
         $projects = $area[1];
         shuffle($projects);

doc/help_vol_edit.php

Braces +36 added lines, -12 removed lines

@@ -79,27 +79,51 @@
 
 function get_form_data() {
     $vol->name = stripslashes($_GET['volname']);
-    if (!$vol->name) boinc_error_page("Name must not be blank");
-    if (strstr($vol->name, "<")) boinc_error_page("No &lt; allowed");
+    if (!$vol->name) {
+        boinc_error_page("Name must not be blank");
+    }
+    if (strstr($vol->name, "<")) {
+        boinc_error_page("No &lt; allowed");
+    }
     $vol->password = stripslashes($_GET['password']);
-    if (!$vol->password) boinc_error_page("Password must not be blank");
+    if (!$vol->password) {
+        boinc_error_page("Password must not be blank");
+    }
     $vol->email_addr = stripslashes($_GET['email_addr']);
-    if (!$vol->email_addr) boinc_error_page("Email address must not be blank");
+    if (!$vol->email_addr) {
+        boinc_error_page("Email address must not be blank");
+    }
     $vol->skypeid = stripslashes($_GET['skypeid']);
-    if (!$vol->skypeid) boinc_error_page("Skype ID must not be blank");
+    if (!$vol->skypeid) {
+        boinc_error_page("Skype ID must not be blank");
+    }
     $vol->lang1 = stripslashes($_GET['lang1']);
-    if (!$vol->lang1) boinc_error_page("Primary language must not be blank");
-    if (!is_spoken_language($vol->lang1)) boinc_error_page("Not a language");
+    if (!$vol->lang1) {
+        boinc_error_page("Primary language must not be blank");
+    }
+    if (!is_spoken_language($vol->lang1)) {
+        boinc_error_page("Not a language");
+    }
     $vol->lang2 = stripslashes($_GET['lang2']);
-    if (!is_spoken_language($vol->lang2)) boinc_error_page("Not a language");
+    if (!is_spoken_language($vol->lang2)) {
+        boinc_error_page("Not a language");
+    }
     $vol->country = stripslashes($_GET['country']);
-    if (!is_valid_country($vol->country)) boinc_error_page("Bad country");
+    if (!is_valid_country($vol->country)) {
+        boinc_error_page("Bad country");
+    }
     $vol->specialties = stripslashes($_GET['specialties']);
-    if (strstr($vol->specialties, "<")) boinc_error_page("No &lt; allowed");
+    if (strstr($vol->specialties, "<")) {
+        boinc_error_page("No &lt; allowed");
+    }
     $vol->projects = stripslashes($_GET['projects']);
-    if (strstr($vol->projects, "<")) boinc_error_page("No &lt; allowed");
+    if (strstr($vol->projects, "<")) {
+        boinc_error_page("No &lt; allowed");
+    }
     $vol->availability = stripslashes($_GET['availability']);
-    if (strstr($vol->availability, "<")) boinc_error_page("No &lt; allowed");
+    if (strstr($vol->availability, "<")) {
+        boinc_error_page("No &lt; allowed");
+    }
     $vol->voice_ok = $_GET['voice_ok']?1:0;
     $vol->text_ok = $_GET['text_ok']?1:0;
     $vol->hide = $_GET['hide']?1:0;

doc/docutil.php

Braces +3 added lines, -1 removed lines

@@ -160,7 +160,9 @@
 }
 
 function list_item($x, $y, $z=null) {
-    if (!$x) $x = "<br>";
+    if (!$x) {
+        $x = "<br>";
+    }
     echo "
         <tr>
             <td class=fieldname valign=top><b>$x</b></td>