BOINC / boinc

sched/transitioner_catchup.php

Braces +3 added lines, -1 removed lines

@@ -28,7 +28,9 @@
     while (1) {
         $now = time();
         $wus = BoincWorkunit::enum("transition_time<$now limit 1");
-        if (count($wus) == 0) break;
+        if (count($wus) == 0) {
+            break;
+        }
         echo "Some WUs need transition - running transitioner.\n";
         $ret = system("bin/transitioner --one_pass");
         echo "ret: $ret\n";

doc/logo.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 
 function art_list_show($logos) {
     shuffle($logos);
-    foreach($logos as $logo) {
+    foreach ($logos as $logo) {
         $x0 = $logo[0];
         $x1 = $logo[1];
         echo "<tr>

doc/help_lang.php

Braces +23 added lines, -11 removed lines

@@ -45,17 +45,29 @@
         return "<font size=-2>(no ratings)</font>";
     }
     $x = $vol->rating_sum/$vol->nratings;
-    if ($x > 4.5) $img = "stars-5-0.gif";
-    else if ($x > 4.0) $img = "stars-4-5.gif";
-    else if ($x > 3.5) $img = "stars-4-0.gif";
-    else if ($x > 3.0) $img = "stars-3-5.gif";
-    else if ($x > 2.5) $img = "stars-3-0.gif";
-    else if ($x > 2.0) $img = "stars-2-5.gif";
-    else if ($x > 1.5) $img = "stars-2-0.gif";
-    else if ($x > 1.0) $img = "stars-1-5.gif";
-    else if ($x > 0.5) $img = "stars-1-0.gif";
-    else if ($x > 0.0) $img = "stars-0-5.gif";
-    else $img = "stars-0-0.gif";
+    if ($x > 4.5) {
+        $img = "stars-5-0.gif";
+    } else if ($x > 4.0) {
+        $img = "stars-4-5.gif";
+    } else if ($x > 3.5) {
+        $img = "stars-4-0.gif";
+    } else if ($x > 3.0) {
+        $img = "stars-3-5.gif";
+    } else if ($x > 2.5) {
+        $img = "stars-3-0.gif";
+    } else if ($x > 2.0) {
+        $img = "stars-2-5.gif";
+    } else if ($x > 1.5) {
+        $img = "stars-2-0.gif";
+    } else if ($x > 1.0) {
+        $img = "stars-1-5.gif";
+    } else if ($x > 0.5) {
+        $img = "stars-1-0.gif";
+    } else if ($x > 0.0) {
+        $img = "stars-0-5.gif";
+    } else {
+        $img = "stars-0-0.gif";
+    }
     return "
         <nobr><a href=help_ratings.php?volid=$vol->id>
         <img border=0 src=images/help/$img>

doc/sim/sim_scenario.php

Spacing +8 added lines, -8 removed lines

@@ -4,11 +4,11 @@ 
 class PROJECT {
     public $name;
     public $resource_share;
-    public $has_cpu;        // whether it has a CPU app
-    public $cpu_ncpus;      // # CPUS used by CPU app
-    public $cpu_flops;      // speed of CPU app
-    public $cpu_job_size;   // size of jobs
-    public $cpu_latency;    // latency of CPU jobs
+    public $has_cpu; // whether it has a CPU app
+    public $cpu_ncpus; // # CPUS used by CPU app
+    public $cpu_flops; // speed of CPU app
+    public $cpu_job_size; // size of jobs
+    public $cpu_latency; // latency of CPU jobs
 
     public $has_gpu;
     public $gpu_ncpus;
@@ -112,7 +112,7 @@ 
 
 function big_scenario() {
     $pp = array();
-    for ($i=0; $i<1; $i++) {
+    for ($i = 0; $i < 1; $i++) {
         $p = new PROJECT;
         $p->name = "C_$i";
         $p->resource_share = 100;
@@ -123,7 +123,7 @@ 
         $p->cpu_latency = 864000;
         $pp[] = $p;
     }
-    for ($i=0; $i<1; $i++) {
+    for ($i = 0; $i < 1; $i++) {
         $p = new PROJECT;
         $p->name = "G_$i";
         $p->resource_share = 100;
@@ -134,7 +134,7 @@ 
         $p->gpu_latency = 864000;
         $pp[] = $p;
     }
-    for ($i=0; $i<1; $i++) {
+    for ($i = 0; $i < 1; $i++) {
         $p = new PROJECT;
         $p->name = "CG_$i";
         $p->resource_share = 100;

doc/sim/sim_web.php

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
 require_once("../inc/util.inc");
 require_once("../inc/sim_util.inc");
 
-ini_set ("memory_limit", "1G");
+ini_set("memory_limit", "1G");
 set_time_limit(0);
 
 function get_comments($dir) {
@@ -63,7 +63,7 @@ 
     $user = BoincUser::lookup_id($userid);
     $date = date_str(filemtime("scenarios/$f"));
     $nsims = nsims($f);
-    $name = $user?$user->name:"???";
+    $name = $user ? $user->name : "???";
     echo "<tr>
         <td><a href=sim_web.php?action=show_scenario&name=$f>$f</a></td>
         <td>$name</td>

Braces +30 added lines, -10 removed lines

@@ -30,13 +30,21 @@ 
 
 function get_comments($dir) {
     $d = "$dir/comments";
-    if (!is_dir($d)) return null;
+    if (!is_dir($d)) {
+        return null;
+    }
     $dd = opendir($d);
     $x = "";
     while (false !== ($f = readdir($dd))) {
-        if ($f == ".") continue;
-        if ($f == "..") continue;
-        if (strlen($x)) $x .= "<hr>\n";
+        if ($f == ".") {
+            continue;
+        }
+        if ($f == "..") {
+            continue;
+        }
+        if (strlen($x)) {
+            $x .= "<hr>\n";
+        }
         $userid = (int)file_get_contents("$d/$f/userid");
         $user = BoincUser::lookup_id($userid);
         $comment = file_get_contents("$d/$f/comment");
@@ -50,8 +58,12 @@ 
     $d = opendir("scenarios/$scen/simulations");
     $n = 0;
     while (false !== ($f = readdir($d))) {
-        if ($f == ".") continue;
-        if ($f == "..") continue;
+        if ($f == ".") {
+            continue;
+        }
+        if ($f == "..") {
+            continue;
+        }
         $n++;
     }
     return $n;
@@ -174,8 +186,12 @@ 
     $d = opendir("scenarios");
     $dirs = array();
     while (false !== ($f = readdir($d))) {
-        if ($f === ".") continue;
-        if ($f === "..") continue;
+        if ($f === ".") {
+            continue;
+        }
+        if ($f === "..") {
+            continue;
+        }
         $dirs[] = $f;
     }
     rsort($dirs);
@@ -338,7 +354,9 @@ 
     $dirs = array();
     $s = opendir("$d/simulations");
     while (false !== ($f = readdir($s))) {
-        if (!is_numeric($f)) continue;
+        if (!is_numeric($f)) {
+            continue;
+        }
         $dirs[] = $f;
     }
     rsort($dirs);
@@ -515,7 +533,9 @@ 
 }
 
 $action = get_str("action", true);
-if (!$action) $action = post_str("action", true);
+if (!$action) {
+    $action = post_str("action", true);
+}
 
 switch ($action) {
 case "create_scenario_form":

doc/sim/sim_util.inc

Spacing +2 added lines, -2 removed lines

@@ -185,10 +185,10 @@
 function graph_n_results2(
     $title, $xlabel, $lab1, $lab2, $dir, $results1, $results2, $col
 ) {
-    for ($i=0; $i<2; $i++) {
+    for ($i = 0; $i < 2; $i++) {
         $data_fname = "$dir/cr_$i.dat";
         $f = fopen($data_fname, "w");
-        $rr = $i?$results2:$results1;
+        $rr = $i ? $results2 : $results1;
         foreach ($rr as $r) {
             $r->write($f);
         }

Braces +15 added lines, -5 removed lines

@@ -76,10 +76,18 @@ 
 //
 function do_sim($in, $out, $policy) {
     $args = "";
-    if ($policy->existing_jobs_only) $args .= " --existing_jobs_only";
-    if ($policy->cpu_sched_rr_only) $args .= " --cpu_sched_rr_only";
-    if ($policy->include_empty_projects) $args .= " --include_empty_projects";
-    if ($policy->server_uses_workload) $args .= " --server_uses_workload";
+    if ($policy->existing_jobs_only) {
+        $args .= " --existing_jobs_only";
+    }
+    if ($policy->cpu_sched_rr_only) {
+        $args .= " --cpu_sched_rr_only";
+    }
+    if ($policy->include_empty_projects) {
+        $args .= " --include_empty_projects";
+    }
+    if ($policy->server_uses_workload) {
+        $args .= " --server_uses_workload";
+    }
     $args .= " --duration $policy->duration";
     $args .= " --delta $policy->delta";
     $args .= " --rec_half_life $policy->rec_half_life";
@@ -221,7 +229,9 @@ 
     $cs_template_fname = "$scenario/client_state_template.xml";
     $cs_fname = "$scenario/client_state.xml";
     $cs = file_get_contents($cs_template_fname);
-    if (!$cs) die("no file $cs_template_fname");
+    if (!$cs) {
+        die("no file $cs_template_fname");
+    }
     $cs = str_replace("PARAM", $param, $cs);
     file_put_contents($cs_fname, $cs);
     do_sim($scenario, $sim_out_dir, $policy);

doc/sim/sim_control.php

Spacing +2 added lines, -2 removed lines

@@ -140,7 +140,7 @@ 
 }
 
 if (0) {
-    $duration = 50* 86400;
+    $duration = 50*86400;
     $p1 = new POLICY("JS_LOCAL");
     $p2 = new POLICY("JS_GLOBAL");
     $p2->use_rec = true;
@@ -170,7 +170,7 @@ 
     $lo = 5*86400;
     $hi = 40*86400;
     $inc = 5*86400;
-    $duration = 50* 86400;
+    $duration = 50*86400;
     compare_policy_params("Resource share violation", "REC half-life", "JS_LOCAL", "JS_GLOBAL", array("scen3"), $p1, $p2, $lo, $hi, $inc, "test7");
 }
 

doc/help_db.php

Braces +9 added lines, -3 removed lines

@@ -111,7 +111,9 @@ 
 
 function vol_lookup($id) {
     $result = mysql_query("select * from volunteer where id=$id");
-    if (!$result) return null;
+    if (!$result) {
+        return null;
+    }
     $vol = mysql_fetch_object($result);
     mysql_free_result($result);
     return $vol;
@@ -120,7 +122,9 @@ 
 function vol_lookup_email($email) {
     $email = mysql_real_escape_string($email);
     $result = mysql_query("select * from volunteer where email_addr='$email'");
-    if (!$result) return null;
+    if (!$result) {
+        return null;
+    }
     $vol = mysql_fetch_object($result);
     mysql_free_result($result);
     return $vol;
@@ -129,7 +133,9 @@ 
 function vol_lookup_name($name) {
     $name = mysql_real_escape_string($name);
     $result = mysql_query("select * from volunteer where name='$name'");
-    if (!$result) return null;
+    if (!$result) {
+        return null;
+    }
     $vol = mysql_fetch_object($result);
     mysql_free_result($result);
     return $vol;

doc/get_platforms.inc

Spacing +5 added lines, -5 removed lines

@@ -228,7 +228,7 @@ 
     libxml_use_internal_errors(true);
     $s = simplexml_load_string($x);
     $list = null;
-    foreach($s->application as $a) {
+    foreach ($s->application as $a) {
         foreach ($a->version as $v) {
             if (!array_key_exists('platform_short', $v)) continue;
             $p = $v->platform_short[0];
@@ -252,7 +252,7 @@ 
 function make_friendly_string($l, $comma) {
     if (!count($l)) return "Unknown";
     $fn = array();
-    foreach($l as $p) {
+    foreach ($l as $p) {
         $p = friendly_name($p);
         if (!$p) continue;
         $fn[] = $p;
@@ -260,7 +260,7 @@ 
     $fn = array_unique($fn);
     $x = "";
     $first = true;
-    foreach($fn as $p) {
+    foreach ($fn as $p) {
         if ($first) {
             $x .= "$p";
             $first = false;
@@ -303,7 +303,7 @@ 
 
 // return platforms as a human-readable string
 //
-function get_platforms_string($url, $comma=true) {
+function get_platforms_string($url, $comma = true) {
     $l = get_platforms_cached($url);
     return make_friendly_string($l, $comma);
 }
@@ -334,7 +334,7 @@ 
 //
 function wfPlatforms() {
     global $wgParser;
-    $wgParser->setHook( "platforms", "get_platforms_string" );
+    $wgParser->setHook("platforms", "get_platforms_string");
 }
 
 $wgExtensionFunctions[] = "wfPlatforms";

Braces +90 added lines, -32 removed lines

@@ -13,8 +13,12 @@ 
         $pc = substr($x[1], 0, -1);
     }
 
-    if (strstr($p, "fubar")) return null;
-    if ($p == 'x86_64-unknown-linux-gnu') return null;
+    if (strstr($p, "fubar")) {
+        return null;
+    }
+    if ($p == 'x86_64-unknown-linux-gnu') {
+        return null;
+    }
     $q = $p;
     switch ($p) {
     case 'i686-pc-linux-gnu': $q = 'Linux/x86'; break;
@@ -39,13 +43,21 @@ 
     case 'arm-unknown-linux-gnueabihf': $q = 'Linux on ARM (e.g., Raspberry Pi)';
     }
     if (strlen($pc)) {
-        if (strstr($pc, 'cuda')) $q .= " (NVIDIA GPU)";
-        else if (strstr($pc, 'nvidia')) $q .= " (NVIDIA GPU)";
-        else if (strstr($pc, 'ati')) $q .= " (AMD/ATI GPU)";
-        else if (strstr($pc, 'intel_gpu')) $q .= " (Intel GPU)";
-        else if (strstr($pc, 'mt')) $q .= " (multicore)";
-        else if (strstr($pc, 'vbox32')) $q .= " (VirtualBox 32-bit)";
-        else if (strstr($pc, 'vbox64')) $q .= " (VirtualBox 64-bit)";
+        if (strstr($pc, 'cuda')) {
+            $q .= " (NVIDIA GPU)";
+        } else if (strstr($pc, 'nvidia')) {
+            $q .= " (NVIDIA GPU)";
+        } else if (strstr($pc, 'ati')) {
+            $q .= " (AMD/ATI GPU)";
+        } else if (strstr($pc, 'intel_gpu')) {
+            $q .= " (Intel GPU)";
+        } else if (strstr($pc, 'mt')) {
+            $q .= " (multicore)";
+        } else if (strstr($pc, 'vbox32')) {
+            $q .= " (VirtualBox 32-bit)";
+        } else if (strstr($pc, 'vbox64')) {
+            $q .= " (VirtualBox 64-bit)";
+        }
     }
     return $q;
 }
@@ -71,19 +83,45 @@ 
             $p = $y[0];
             $pc = substr($y[1], 0, -1);
         }
-        if (strstr($p, "windows")) $x->windows = true;
-        if (strstr($p, "darwin")) $x->mac = true;
-        if (strstr($p, "linux")) $x->linux = true;
-        if (strstr($p, "android")) $x->android = true;
-        if (strstr($p, "freebsd")) $x->freebsd = true;
-        if (strstr($p, "arm-unknown-linux-gnueabihf")) $x->rasp_pi = true;
-        if (strstr($p, "armv5")) $x->rasp_pi = true;
-        if (strstr($p, "armv6")) $x->rasp_pi = true;
-        if (strstr($pc, "ati")) $x->amd_gpu = true;
-        if (strstr($pc, "cuda")) $x->nvidia_gpu = true;
-        if (strstr($pc, "nvidia")) $x->nvidia_gpu = true;
-        if (strstr($pc, "intel_gpu")) $x->intel_gpu = true;
-        if (strstr($pc, "vbox")) $x->vbox = true;
+        if (strstr($p, "windows")) {
+            $x->windows = true;
+        }
+        if (strstr($p, "darwin")) {
+            $x->mac = true;
+        }
+        if (strstr($p, "linux")) {
+            $x->linux = true;
+        }
+        if (strstr($p, "android")) {
+            $x->android = true;
+        }
+        if (strstr($p, "freebsd")) {
+            $x->freebsd = true;
+        }
+        if (strstr($p, "arm-unknown-linux-gnueabihf")) {
+            $x->rasp_pi = true;
+        }
+        if (strstr($p, "armv5")) {
+            $x->rasp_pi = true;
+        }
+        if (strstr($p, "armv6")) {
+            $x->rasp_pi = true;
+        }
+        if (strstr($pc, "ati")) {
+            $x->amd_gpu = true;
+        }
+        if (strstr($pc, "cuda")) {
+            $x->nvidia_gpu = true;
+        }
+        if (strstr($pc, "nvidia")) {
+            $x->nvidia_gpu = true;
+        }
+        if (strstr($pc, "intel_gpu")) {
+            $x->intel_gpu = true;
+        }
+        if (strstr($pc, "vbox")) {
+            $x->vbox = true;
+        }
     }
     return $x;
 }
@@ -126,9 +164,15 @@ 
 }
 
 function canonical_plan_class($pc) {
-	if (strstr($pc, "atiOpenCL")) return "opencl_ati";
-	if (strstr($pc, "nvidiaOpenCL")) return "opencl_nvidia";
-	if (strstr($pc, "intelOpenCL")) return "opencl_intel_gpu";
+	if (strstr($pc, "atiOpenCL")) {
+	    return "opencl_ati";
+	}
+	if (strstr($pc, "nvidiaOpenCL")) {
+	    return "opencl_nvidia";
+	}
+	if (strstr($pc, "intelOpenCL")) {
+	    return "opencl_intel_gpu";
+	}
     return $pc;
 }
 
@@ -136,10 +180,16 @@ 
 //
 function valid($url, $plat) {
     if (strstr($url, "gpugrid.net")) {
-        if (strstr($plat, "android")) return false;
-        if (strstr($plat, "vbox")) return false;
+        if (strstr($plat, "android")) {
+            return false;
+        }
+        if (strstr($plat, "vbox")) {
+            return false;
+        }
     } else if (strstr($url, "csgrid")) {
-        if (strstr($plat, "android")) return false;
+        if (strstr($plat, "android")) {
+            return false;
+        }
     }
     return true;
 }
@@ -165,7 +215,9 @@ 
 //   ...
 //
 function get_platforms($url) {
-    if (strstr($url, "radioactive")) return null;
+    if (strstr($url, "radioactive")) {
+        return null;
+    }
     $url .= 'get_project_config.php';
     $x = @file_get_contents($url);
     if (!$x) {
@@ -230,7 +282,9 @@ 
     $list = null;
     foreach($s->application as $a) {
         foreach ($a->version as $v) {
-            if (!array_key_exists('platform_short', $v)) continue;
+            if (!array_key_exists('platform_short', $v)) {
+                continue;
+            }
             $p = $v->platform_short[0];
             $pc = "";
             if (array_key_exists('plan_class', $v)) {
@@ -250,11 +304,15 @@ 
 // list of human-readable names
 //
 function make_friendly_string($l, $comma) {
-    if (!count($l)) return "Unknown";
+    if (!count($l)) {
+        return "Unknown";
+    }
     $fn = array();
     foreach($l as $p) {
         $p = friendly_name($p);
-        if (!$p) continue;
+        if (!$p) {
+            continue;
+        }
         $fn[] = $p;
     }
     $fn = array_unique($fn);