BOINC / boinc

html/user/buda.php

Spacing +6 added lines, -6 removed lines

@@ -36,7 +36,7 @@ 
 // show list of BUDA apps and variants,
 // w/ buttons for adding and deleting
 //
-function app_list($notice=null) {
+function app_list($notice = null) {
     global $buda_root;
     if (!is_dir($buda_root)) {
         mkdir($buda_root);
@@ -224,7 +224,7 @@ 
     //
     $x = "<input_template>\n";
     $ninfiles = count($desc->input_file_names);
-    for ($i=0; $i<$ninfiles; $i++) {
+    for ($i = 0; $i < $ninfiles; $i++) {
         $x .= "   <file_info>\n      <sticky/>\n      <no_delete/>\n      <executable/>\n   </file_info>\n";
     }
     $x .= "   <workunit>\n";
@@ -245,7 +245,7 @@ 
     );
 
     $x .= sprintf("      <max_delay>%f</max_delay>\n",
-        $desc->max_delay_days * 86400.
+        $desc->max_delay_days*86400.
     );
 
     $x .= "      <buda_app_name>$app</buda_app_name>\n";
@@ -318,7 +318,7 @@ 
     } else {
         $creating = true;
     }
-    $variant = sprintf('%s_%s', $cpu_type, $plan_class?$plan_class:'cpu');
+    $variant = sprintf('%s_%s', $cpu_type, $plan_class ? $plan_class : 'cpu');
     if (!is_valid_filename($variant)) {
         error_page(filename_rules());
     }
@@ -463,8 +463,8 @@ 
     }
 }
 
-function app_form($desc=null) {
-    page_head_select2($desc?"Edit BUDA app $desc->name":'Create BUDA app');
+function app_form($desc = null) {
+    page_head_select2($desc ? "Edit BUDA app $desc->name" : 'Create BUDA app');
     form_start('buda.php');
     form_input_hidden('action', 'app_action');
     if ($desc) {

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -195,7 +195,7 @@ 
         );
     }
     form_input_text("Plan class$pc", 'plan_class', $variant_desc->plan_class);
-    form_select("Dockerfile$sb", 'dockerfile', $sbitems, $variant_desc->dockerfile);
+    form_select("dockerfile$sb", 'dockerfile', $sbitems, $variant_desc->dockerfile);
     form_select2_multi("Application files$sb", 'app_files', $sbitems, $variant_desc->app_files);
     form_submit('OK');
     form_end();
@@ -393,7 +393,7 @@ 
     // Note: we don't currently allow indirect file access.
     // If we did, we'd need to create job.toml to mount project dir
 
-    app_list("Variant $variant added for app $app.");
+    app_list("variant $variant added for app $app.");
 }
 
 function variant_delete() {
@@ -420,7 +420,7 @@ 
         if ($ret) {
             error_page("delete failed");
         }
-        $notice = "Variant $variant of app $app removed.";
+        $notice = "variant $variant of app $app removed.";
         app_list($notice);
     } else {
         page_head("Confirm");
@@ -450,7 +450,7 @@ 
         if ($ret) {
             error_page('delete failed');
         }
-        $notice = "App $app removed.";
+        $notice = "app $app removed.";
         app_list($notice);
     } else {
         page_head('Confirm');
@@ -547,7 +547,7 @@ 
         }
         $dir = "$buda_root/$app_name";
         if (file_exists($dir)) {
-            error_page("App $app_name already exists.");
+            error_page("app $app_name already exists.");
         }
         mkdir($dir);
         $desc->user_id = $user->id;

html/user/download_software.php

Spacing +1 added lines, -1 removed lines

@@ -346,7 +346,7 @@
     handle_get_info();
 } else {
     $dev = get_str("dev", true);
-    $user_agent = get_str("user_agent", true);      // for debugging
+    $user_agent = get_str("user_agent", true); // for debugging
     if (!$user_agent) {
         $user_agent = $_SERVER['HTTP_USER_AGENT'];
     }

html/user/manage_project.php

Spacing +7 added lines, -7 removed lines

@@ -38,7 +38,7 @@ 
             $app = BoincApp::lookup_id($ua->app_id);
             $names[] = $app->name;
         }
-        $sub = $names?implode(', ', $names):'---';
+        $sub = $names ?implode(', ', $names) : '---';
     }
     if ($u->manage_all) {
         $admin = 'All applications';
@@ -49,7 +49,7 @@ 
             $app = BoincApp::lookup_id($ua->app_id);
             $names[] = $app->name;
         }
-        $admin = $names?implode(', ', $names):'---';
+        $admin = $names ?implode(', ', $names) : '---';
     }
     [$yes, $no] = read_kw_prefs($user);
     global $job_keywords;
@@ -69,7 +69,7 @@ 
         implode('<br>', $kws),
         $u->quota,
         $u->max_jobs_in_progress,
-        ($u->logical_start_time > time())?local_time_str($u->logical_start_time):'---'
+        ($u->logical_start_time > time()) ?local_time_str($u->logical_start_time) : '---'
     );
 }
 
@@ -148,7 +148,7 @@ 
         'max_jobs_in_progress', $usub->max_jobs_in_progress
     );
     form_general('Run jobs only on own computers?',
-        $user->seti_id?'yes':'no'
+        $user->seti_id ? 'yes' : 'no'
     );
     form_submit('Update');
     form_end();
@@ -204,18 +204,18 @@ 
     $manage_apps = array_map('intval', $manage_apps);
     foreach ($apps as $app) {
         $s = in_array($app->id, $submit_apps);
-        $m = in_array($app->id, $manage_apps)?1:0;
+        $m = in_array($app->id, $manage_apps) ? 1 : 0;
         if ($s || $m) {
             BoincUserSubmitApp::insert(
                 "(user_id, app_id, manage) values ($user_id, $app->id, $m)"
             );
         }
     }
-    $quota = (double) get_str('quota');
+    $quota = (double)get_str('quota');
     if ($quota != $us->quota) {
         $us->update("quota=$quota");
     }
-    $mj = (int) get_str('max_jobs_in_progress');
+    $mj = (int)get_str('max_jobs_in_progress');
     if ($mj != $us->max_jobs_in_progress) {
         $us->update("max_jobs_in_progress=$mj");
     }

html/user/submit.php

Spacing +5 added lines, -5 removed lines

@@ -674,7 +674,7 @@ 
         );
     }
     row2("Submitted", time_str($batch->create_time));
-    row2("Application", $app?$app->name:'---');
+    row2("Application", $app ? $app->name : '---');
     row2("State", batch_state_string($batch->state));
     //row2("# jobs", $batch->njobs);
     //row2("# error jobs", $batch->nerror_jobs);
@@ -764,11 +764,11 @@ 
         "GFLOPS-hours"
     ];
     row_heading_array($x);
-    foreach($wus as $wu) {
+    foreach ($wus as $wu) {
         if ($status && $wu->status != $status) continue;
         $y = '';
         $c = '---';
-        switch($wu->status) {
+        switch ($wu->status) {
         case WU_SUCCESS:
             $resultid = $wu->canonical_resultid;
             $y = sprintf('<font color="%s">completed</font>', COLOR_SUCCESS);
@@ -859,7 +859,7 @@ 
             if ($result->id == $wu->canonical_resultid) {
                 $log_names = get_outfile_log_names($result);
                 $nfiles = count($log_names);
-                for ($i=0; $i<$nfiles; $i++) {
+                for ($i = 0; $i < $nfiles; $i++) {
                     $name = $log_names[$i];
                     // don't show 'view' link if it's a .zip
                     $y = "$name: ";
@@ -883,7 +883,7 @@ 
                 $phys_names = get_outfile_phys_names($result);
                 $log_names = get_outfile_log_names($result);
                 $nfiles = count($log_names);
-                for ($i=0; $i<$nfiles; $i++) {
+                for ($i = 0; $i < $nfiles; $i++) {
                     $path = dir_hier_path(
                         $phys_names[$i], $upload_dir, $fanout
                     );

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -661,7 +661,7 @@ 
 
     $is_assim_move = is_assim_move($app);
 
-    page_head("Batch $batch_id");
+    page_head("batch $batch_id");
     text_start(800);
     start_table();
     row2("Batch name", $batch->name);
@@ -963,7 +963,7 @@ 
 
     if (get_int('confirmed', true)) {
         abort_batch($batch);
-        page_head("Batch $batch_id aborted");
+        page_head("batch $batch_id aborted");
         return_link();
         page_tail();
     } else {
@@ -993,7 +993,7 @@ 
 
     if (get_int('confirmed', true)) {
         retire_batch($batch);
-        page_head("Batch $batch_id retired");
+        page_head("batch $batch_id retired");
         return_link();
         page_tail();
     } else {

html/inc/util_basic.inc

Spacing +6 added lines, -6 removed lines

@@ -56,10 +56,10 @@ 
     return file_exists("$d/stop_sched");
 }
 
-function xml_error($num=-1, $msg=null, $file=null, $line=null) {
+function xml_error($num = -1, $msg = null, $file = null, $line = null) {
     global $xml_outer_tag;
     if (!$msg) {
-        switch($num) {
+        switch ($num) {
         case -112: $msg = "Invalid XML"; break;
         case -136: $msg = "Not found"; break;
         case -137: $msg = "Name or email address is not unique"; break;
@@ -104,7 +104,7 @@ 
 // If it's a single-tag element, and it's present, just return the tag
 //
 function parse_element($xml, $tag) {
-    $closetag = "</" . substr($tag,1);
+    $closetag = "</".substr($tag, 1);
     $x = strstr($xml, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -120,8 +120,8 @@ 
 
 function parse_next_element($xml, $tag, &$cursor) {
     $element = null;
-    $closetag = "</" . substr($tag,1);
-    $pos = substr($xml,$cursor);
+    $closetag = "</".substr($tag, 1);
+    $pos = substr($xml, $cursor);
     $x = strstr($pos, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -222,7 +222,7 @@ 
 // ALSO: allow spaces.
 //
 function is_valid_filename($x) {
-    if (strlen($x)>255) return false;
+    if (strlen($x) > 255) return false;
     // \w means A-Za-z0-9_
     return preg_match('/^[\w\-. ]+$/', $x);
 }

html/ops/submit_retire.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
     foreach ($batches as $batch) {
         $n = BoincWorkunit::count("batch=$batch->id");
         if ($n == 0) {
-            echo "Batch $batch->id has no jobs\n";
+            echo "batch $batch->id has no jobs\n";
             retire_batch($batch);
         }
     }

html/user/buda_submit.php

Spacing +7 added lines, -7 removed lines

@@ -96,7 +96,7 @@ 
 //
 function unzip_batch_file($user, $batch_file) {
     @mkdir("../../buda_batches");
-    for ($i=0; $i<1000; $i++) {
+    for ($i = 0; $i < 1000; $i++) {
         $batch_dir = "../../buda_batches/$i";
         $batch_dir_name = $i;
         $ret = @mkdir($batch_dir);
@@ -147,7 +147,7 @@ 
         }
         $job_files = [];
         $cmdline = '';
-        foreach(scandir("$batch_dir/$fname") as $f2) {
+        foreach (scandir("$batch_dir/$fname") as $f2) {
             if ($f2[0] == '.') continue;
             if ($f2 == 'cmdline') {
                 $cmdline = trim(file_get_contents("$batch_dir/$fname/cmdline"));
@@ -201,7 +201,7 @@ 
 function stage_input_files($batch_dir, $batch_desc, $batch_id) {
     $n = count($batch_desc->shared_files);
     $batch_desc->shared_files_phys_names = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $path = sprintf('%s/%s', $batch_dir, $batch_desc->shared_files[$i]);
         [$md5, $size] = $batch_desc->shared_file_infos[$i];
         $phys_name = sprintf('batch_%d_%s', $batch_id, $md5);
@@ -211,7 +211,7 @@ 
     foreach ($batch_desc->jobs as $job) {
         $n = count($batch_desc->unshared_files);
         $job->phys_names = [];
-        for ($i=0; $i<$n; $i++) {
+        for ($i = 0; $i < $n; $i++) {
             $path = sprintf('%s/%s/%s',
                 $batch_dir, $job->dir, $batch_desc->unshared_files[$i]
             );
@@ -250,7 +250,7 @@ 
         $job_cmds .= "$job_cmd\n";
     }
     $wrapper_cmdline = sprintf('"%s %s"',
-        $wrapper_verbose?'--verbose':'',
+        $wrapper_verbose ? '--verbose' : '',
         $cmdline
     );
     $cmd = sprintf(
@@ -301,7 +301,7 @@ 
     if ($max_runtime_days <= 0) error_page('bad runtime limit');
     if ($max_runtime_days > 100) error_page('bad runtime limit');
 
-    $max_fpops = $max_runtime_days * AVG_CPU_FPOPS * 86400;
+    $max_fpops = $max_runtime_days*AVG_CPU_FPOPS*86400;
 
     $exp_runtime_days = get_str('exp_runtime_days');
     if (!is_numeric($exp_runtime_days)) error_page('bad expected runtime');
@@ -311,7 +311,7 @@ 
     if ($exp_runtime_days > $max_runtime_days) {
         error_page('exp must be < max runtime');
     }
-    $exp_fpops = $exp_runtime_days * AVG_CPU_FPOPS * 86400;
+    $exp_fpops = $exp_runtime_days*AVG_CPU_FPOPS*86400;
 
     $app_desc = get_buda_app_desc($app);