Passed
Pull Request — master (#6635)
by Vitalii
14:21 queued 05:48
created
html/user/sample_index.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,10 +58,10 @@
 block discarded – undo
58 58
     //panel(null, 'panel_contents');
59 59
 }
60 60
 
61
-function left(){
61
+function left() {
62 62
     global $user, $no_web_account_creation, $project_id;
63 63
     panel(
64
-        $user?tra("Welcome, %1", $user->name):tra("What is %1?", PROJECT),
64
+        $user ?tra("Welcome, %1", $user->name) : tra("What is %1?", PROJECT),
65 65
         function() use($user) {
66 66
             global $no_web_account_creation, $project_id;
67 67
             if ($user) {
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
     //panel(null, 'panel_contents');
59 59
 }
60 60
 
61
-function left(){
61
+function left() {
62 62
     global $user, $no_web_account_creation, $project_id;
63 63
     panel(
64 64
         $user?tra("Welcome, %1", $user->name):tra("What is %1?", PROJECT),
Please login to merge, or discard this patch.
html/user/create_profile.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 // If $selection is provided, and if it matches one of the entries in the file,
33 33
 // it will be selected by default.
34 34
 //
35
-function show_combo_box($name, $filename, $selection=null) {
35
+function show_combo_box($name, $filename, $selection = null) {
36 36
     echo "<select name=\"$name\" class=\"form-control\">\n";
37 37
 
38 38
     $file = fopen($filename, "r");
@@ -63,14 +63,14 @@  discard block
 block discarded – undo
63 63
 <tr><td colspan=2>
64 64
 <table border=0 cellpadding=5
65 65
 <tr>
66
-<td valign=top><a href=\"" . IMAGE_URL . $profile->userid . '.jpg' . "\"><img src=\"" . IMAGE_URL . $profile->userid . '_sm.jpg' . "\"></a>
66
+<td valign=top><a href=\"" . IMAGE_URL.$profile->userid.'.jpg'."\"><img src=\"".IMAGE_URL.$profile->userid.'_sm.jpg'."\"></a>
67 67
 </td>
68
-<td valign=top>" .tra("%1 Your profile picture is shown to the left.",  $warning) ."
68
+<td valign=top>" .tra("%1 Your profile picture is shown to the left.", $warning)."
69 69
 <p>".
70
-tra("To replace it, click the \"Browse\" button and select a JPEG or PNG file (%1 or less).", "50KB") ."<br />
70
+tra("To replace it, click the \"Browse\" button and select a JPEG or PNG file (%1 or less).", "50KB")."<br />
71 71
 <input name=picture type=file><br>
72 72
 <p>".
73
-tra("To remove it from your profile, check this box:") . "
73
+tra("To remove it from your profile, check this box:")."
74 74
 <input type=checkbox name=delete_pic>
75 75
 <p>
76 76
 </td></tr>";
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
         end_table();
79 79
         echo "</td></tr>";
80 80
     } else {
81
-        rowify(tra("If you would like include a picture with your profile, click the \"Browse\" button and select a JPEG or PNG file. Please select images of %1 or less.", "50KB") . "
81
+        rowify(tra("If you would like include a picture with your profile, click the \"Browse\" button and select a JPEG or PNG file. Please select images of %1 or less.", "50KB")."
82 82
 <p>
83 83
 <input name=picture type=file>
84 84
         ");
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     row1(tra("Language"));
94 94
     echo "<tr><td>
95 95
         <p>" .
96
-        tra("Select the language in which your profile is written:") . "
96
+        tra("Select the language in which your profile is written:")."
97 97
         <p>
98 98
     ";
99 99
     if (isset($profile->language)) {
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
     if (recaptcha_public_key()) {
110 110
         table_row(boinc_recaptcha_get_html(recaptcha_public_key()));
111 111
     }
112
-    table_row("<p><input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Create/edit profile") ."\" name=\"submit\">");
112
+    table_row("<p><input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Create/edit profile")."\" name=\"submit\">");
113 113
 }
114 114
 
115 115
 // Returns an array containing:
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 
124 124
     // Determine if the filetype uploaded is supported.
125 125
     // TODO: Change these to constants.
126
-    switch($size[2]) {
126
+    switch ($size[2]) {
127 127
     case '2':    // JPEG
128 128
         $image = imageCreateFromJPEG($fileName);
129 129
         break;
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
 
161 161
 function show_description() {
162 162
     echo "
163
-        <p>" .tra("Your %1 profile %2 lets you share your opinions and background with the %3 community.", "<b>", "</b>", PROJECT) . "
163
+        <p>" .tra("Your %1 profile %2 lets you share your opinions and background with the %3 community.", "<b>", "</b>", PROJECT)."
164 164
         <p>
165 165
     ";
166 166
 }
@@ -178,14 +178,14 @@  discard block
 block discarded – undo
178 178
     row1(show_profile_heading1());
179 179
     rowify(show_profile_question1().bbcode_info());
180 180
     show_textarea("response1", $response1);
181
-    row1( show_profile_heading2());
182
-    rowify( show_profile_question2().bbcode_info());
181
+    row1(show_profile_heading2());
182
+    rowify(show_profile_question2().bbcode_info());
183 183
     show_textarea("response2", $response2);
184 184
     show_language_selection($profile);
185 185
 }
186 186
 
187 187
 function show_textarea($name, $text) {
188
-    rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">" . $text . "</textarea>");
188
+    rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">".$text."</textarea>");
189 189
 }
190 190
 
191 191
 // $profile is null if user doesn't already have a profile.
@@ -229,8 +229,8 @@  discard block
 block discarded – undo
229 229
         $delete_pic = "off";
230 230
     }
231 231
 
232
-    if (strlen($response1)==0 &&
233
-        strlen($response2)==0 &&
232
+    if (strlen($response1) == 0 &&
233
+        strlen($response2) == 0 &&
234 234
         $delete_pic != "on" &&
235 235
         !is_uploaded_file($_FILES['picture']['tmp_name'])
236 236
     ) {
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
         $profile->verification = 0;
245 245
     }
246 246
 
247
-    $profile ? $has_picture = $profile->has_picture: $has_picture = false;
247
+    $profile ? $has_picture = $profile->has_picture : $has_picture = false;
248 248
 
249 249
     if (is_uploaded_file($_FILES['picture']['tmp_name'])) {
250 250
         $has_picture = true;
@@ -259,13 +259,13 @@  discard block
 block discarded – undo
259 259
 
260 260
         // Write the original image file to disk.
261 261
         // TODO: define a constant for image quality.
262
-        ImageJPEG($images[0], IMAGE_PATH . $user->id . '.jpg');
263
-        ImageJPEG($images[1], IMAGE_PATH . $user->id . '_sm.jpg');
262
+        ImageJPEG($images[0], IMAGE_PATH.$user->id.'.jpg');
263
+        ImageJPEG($images[1], IMAGE_PATH.$user->id.'_sm.jpg');
264 264
     }
265 265
     $response1 = sanitize_html($response1);
266 266
     $response2 = sanitize_html($response2);
267 267
 
268
-    $has_picture = $has_picture?1:0;
268
+    $has_picture = $has_picture ? 1 : 0;
269 269
     if ($profile) {
270 270
         $query = " response1 = '".BoincDb::escape_string($response1)."',"
271 271
             ." response2 = '".BoincDb::escape_string($response2)."',"
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
307 307
     page_tail();
308 308
 }
309 309
 
310
-function show_profile_form($profile, $warning=null) {
310
+function show_profile_form($profile, $warning = null) {
311 311
     if ($profile) {
312 312
         page_head(tra("Edit your profile"), null, null, null, boinc_recaptcha_get_head_extra());
313 313
     } else {
Please login to merge, or discard this patch.
html/user/kw_prefs.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -93,9 +93,9 @@
 block discarded – undo
93 93
     global $job_keywords;
94 94
     $kw = $job_keywords[$id];
95 95
     $u = $uprefs[$id];
96
-    $yes_checked = ($u == KW_YES)?"checked":"";
97
-    $no_checked = ($u == KW_NO)?"checked":"";
98
-    $maybe_checked = ($u == KW_MAYBE)?"checked":"";
96
+    $yes_checked = ($u == KW_YES) ? "checked" : "";
97
+    $no_checked = ($u == KW_NO) ? "checked" : "";
98
+    $maybe_checked = ($u == KW_MAYBE) ? "checked" : "";
99 99
 
100 100
     echo sprintf('<tr id="%s" hidden>%s', "row$id", "\n");
101 101
     echo sprintf('   <td width=50%% id="%s"></td>%s', "text$id", "\n");
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -298,7 +298,7 @@
 block discarded – undo
298 298
 
299 299
     render();
300 300
 
301
-EOT;
301
+eot;
302 302
     echo "</script>\n";
303 303
 }
304 304
 
Please login to merge, or discard this patch.
html/inc/kw_prefs.inc 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -31,14 +31,14 @@
 block discarded – undo
31 31
     if (file_exists($path)) {
32 32
         $x = file($path);
33 33
         $yes = explode(' ', trim($x[0]));
34
-        if ($yes[0]=='') $yes=[];
34
+        if ($yes[0] == '') $yes = [];
35 35
         $yes = array_map('intval', $yes);
36 36
         $no = explode(' ', trim($x[1]));
37
-        if ($no[0]=='') $no=[];
37
+        if ($no[0] == '') $no = [];
38 38
         $no = array_map('intval', $no);
39 39
         return [$yes, $no];
40 40
     } else {
41
-        return [[],[]];
41
+        return [[], []];
42 42
     }
43 43
 }
44 44
 
Please login to merge, or discard this patch.
html/inc/recaptchalib.inc 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 
33 33
 function boinc_recaptcha_get_html($publickey) {
34 34
     if ($publickey) {
35
-        return '<div class="g-recaptcha" data-sitekey="' . $publickey . '"></div>';
35
+        return '<div class="g-recaptcha" data-sitekey="'.$publickey.'"></div>';
36 36
     } else {
37 37
         return '';
38 38
     }
Please login to merge, or discard this patch.
html/inc/submit_util.inc 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
     foreach ($res_in_prog as $res) {
180 180
         $wus_in_prog[$res->workunitid] = true;
181 181
     }
182
-    unset($res_in_progress);    // does this do anything?
182
+    unset($res_in_progress); // does this do anything?
183 183
 
184 184
     $fp_total = 0;
185 185
     $fp_done = 0;
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
 // get the total size of output files of a batch
353 353
 //
354 354
 function batch_output_file_size($batchid) {
355
-    $batch_td_size=0;
355
+    $batch_td_size = 0;
356 356
     $wus = BoincWorkunit::enum_fields(
357 357
         'canonical_resultid',
358 358
         "batch=$batchid"
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
385 385
 }
386 386
 
387 387
 function boinc_get_wu_output_files_url($user, $wu_id) {
388
-    $auth_str =  md5($user->authenticator.$wu_id);
388
+    $auth_str = md5($user->authenticator.$wu_id);
389 389
     return "get_output.php?cmd=workunit_files&wu_id=$wu_id&auth_str=$auth_str";
390 390
 }
391 391
 
@@ -419,7 +419,7 @@  discard block
 block discarded – undo
419 419
     if (!file_exists($path)) return null;
420 420
     $x = file_get_contents($path);
421 421
     $n = sscanf($x, "%s %d", $md5, $size);
422
-    if ($n != 2 || strlen($md5)!=32) {
422
+    if ($n != 2 || strlen($md5) != 32) {
423 423
         return null;
424 424
     }
425 425
     return [$md5, $size];
Please login to merge, or discard this patch.
html/user/json_form.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
 require_once('../inc/util.inc');
6 6
 require_once('../inc/sandbox.inc');
7 7
 
8
-function sb_file_select($user, $suffix=null) {
8
+function sb_file_select($user, $suffix = null) {
9 9
     $sbfiles = sandbox_file_names($user);
10 10
     $sbitems = [];
11 11
     $exp = null;
Please login to merge, or discard this patch.
html/user/weak_auth.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -30,14 +30,14 @@  discard block
 block discarded – undo
30 30
 $master_url = master_url();
31 31
 $idx = strpos($master_url, '://');
32 32
 if ($idx) {
33
-    $url = substr($master_url, $idx+strlen('://'));
33
+    $url = substr($master_url, $idx + strlen('://'));
34 34
 } else {
35 35
     $url = $master_url;
36 36
 }
37 37
 
38 38
 // convert invalid characters into underscores
39 39
 //
40
-for ($i=0; $i<strlen($url); $i++) {
40
+for ($i = 0; $i < strlen($url); $i++) {
41 41
     $c = $url[$i];
42 42
     if (!ctype_alnum($c) && $c != '.' && $c != '-' && $c != '_') {
43 43
         $url[$i] = '_';
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 
47 47
 //remove trailing underscore(s)
48 48
 //
49
-$account_file = "account_" . rtrim($url, '_') . ".xml";
49
+$account_file = "account_".rtrim($url, '_').".xml";
50 50
 
51 51
 page_head(tra("Account keys"));
52 52
 text_start();
@@ -58,12 +58,12 @@  discard block
 block discarded – undo
58 58
     <p>",
59 59
     tra("This key can be used to:"),
60 60
     "<ul>
61
-    <li><a href=get_passwd.php>",tra("log in to your account on the web"),"</a>;
61
+    <li><a href=get_passwd.php>",tra("log in to your account on the web"), "</a>;
62 62
     <li>",
63 63
         tra("attach a computer to your account without using the BOINC Manager.
64 64
        To do so, install BOINC,
65 65
        create a file named %1 in the BOINC
66
-       data directory, and set its contents to:","<b>$account_file</b>"),"
66
+       data directory, and set its contents to:","<b>$account_file</b>"), "
67 67
     <p><pre>",
68 68
     htmlspecialchars(
69 69
 "<account>
@@ -77,10 +77,10 @@  discard block
 block discarded – undo
77 77
     as described above, but cannot be used to log in to your account or change it in any way.
78 78
     If you want to attach untrusted or insecure computers to your account,
79 79
     do so using your weak account key.
80
-    Your weak account key is:"),"
80
+    Your weak account key is:"), "
81 81
     <p><pre>$weak_auth</pre><p>
82 82
     ",
83
-    tra("The key depends on your account's email address and password.  If you change either of these, the weak account key will change."),"
83
+    tra("The key depends on your account's email address and password.  If you change either of these, the weak account key will change."), "
84 84
     </td></tr></table>"
85 85
 ;
86 86
 text_end();
Please login to merge, or discard this patch.
html/user/submit_stats.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -199,25 +199,25 @@  discard block
 block discarded – undo
199 199
     $min = 1e99;
200 200
     $max = 0;
201 201
     foreach ($results as $r) {
202
-        $f = $r->flops / (4.3e9 *3600);
202
+        $f = $r->flops/(4.3e9*3600);
203 203
         if ($f > $max) $max = $f;
204 204
         if ($f < $min) $min = $f;
205 205
         $x[] = $f;
206 206
     }
207 207
     $n = 800;
208 208
     $count = [];
209
-    for ($i=0; $i<$n; $i++) {
209
+    for ($i = 0; $i < $n; $i++) {
210 210
         $count[$i] = 0;
211 211
     }
212 212
     $range = $max - $min;
213 213
     foreach ($x as $f) {
214
-        $d = intval($n*($f-$min)/$range);
215
-        if ($d >= $n) $d = $n-1;
214
+        $d = intval($n*($f - $min)/$range);
215
+        if ($d >= $n) $d = $n - 1;
216 216
         $count[$d] += 1;
217 217
     }
218 218
     $data = [];
219
-    for ($i=0; $i<$n; $i++) {
220
-        $data[] = [$min+($i*$range)/$n, $count[$i]];
219
+    for ($i = 0; $i < $n; $i++) {
220
+        $data[] = [$min + ($i*$range)/$n, $count[$i]];
221 221
     }
222 222
     graph($data, 'hours', 'count');
223 223
     page_tail();
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 
226 226
 $batch = BoincBatch::lookup_id(get_int('batch_id'));
227 227
 if (!$batch) error_page('no batch');
228
-switch(get_str('action')) {
228
+switch (get_str('action')) {
229 229
 case 'err_host':
230 230
     err_host($batch);
231 231
     break;
Please login to merge, or discard this patch.
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 }
193 193
 
194 194
 function flops_graph($batch) {
195
-    page_head("Batch $batch->id job runtimes");
195
+    page_head("batch $batch->id job runtimes");
196 196
     echo "
197 197
     <p>
198 198
     Runtimes of completed jobs, normalized to an average (4.3 GFLOPS) computer.
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
         }
252 252
     }
253 253
     arsort($x);
254
-    page_head("Batch $batch->id: completed jobs grouped by host");
254
+    page_head("batch $batch->id: completed jobs grouped by host");
255 255
     text_start();
256 256
     start_table();
257 257
     table_header('Host', 'OS', '# jobs');
Please login to merge, or discard this patch.