BOINC / boinc

html/user/buda.php

Spacing +9 added lines, -9 removed lines

@@ -54,7 +54,7 @@ 
 // show list of BUDA apps and variants,
 // w/ buttons for adding and deleting
 //
-function app_list($notice=null) {
+function app_list($notice = null) {
     global $buda_root;
     if (!is_dir($buda_root)) {
         mkdir($buda_root);
@@ -256,7 +256,7 @@ 
     //
     $x = "<input_template>\n";
     $ninfiles = 1 + count($variant_desc->input_file_names) + count($variant_desc->app_files);
-    for ($i=0; $i<$ninfiles; $i++) {
+    for ($i = 0; $i < $ninfiles; $i++) {
         $x .= "   <file_info>\n      <sticky/>\n      <no_delete/>\n      <executable/>\n   </file_info>\n";
     }
     $x .= "   <workunit>\n";
@@ -286,7 +286,7 @@ 
     );
 
     $x .= sprintf("      <max_delay>%f</max_delay>\n",
-        $variant_desc->max_delay_days * 86400.
+        $variant_desc->max_delay_days*86400.
     );
 
     $x .= "   </workunit>\n<input_template>\n";
@@ -476,8 +476,8 @@ 
     }
 }
 
-function app_form($desc=null) {
-    page_head_select2($desc?"Edit BUDA app $desc->name":'Create BUDA app');
+function app_form($desc = null) {
+    page_head_select2($desc ? "Edit BUDA app $desc->name" : 'Create BUDA app');
     form_start('buda.php');
     form_input_hidden('action', 'app_action');
     if ($desc) {
@@ -488,22 +488,22 @@ 
         form_input_text('Internal name<br><small>No spaces</small>', 'name');
     }
     form_input_text('User-visible name', 'long_name',
-        $desc?$desc->long_name:null
+        $desc ? $desc->long_name : null
     );
     form_input_textarea(
         'Description<br><small>... of what the app does and of the research goals</small>',
         'description',
-        $desc?$desc->description:null
+        $desc ? $desc->description : null
     );
     form_select2_multi('Science keywords',
         'sci_kw',
         keyword_select_options(KW_CATEGORY_SCIENCE),
-        $desc?$desc->sci_kw:null
+        $desc ? $desc->sci_kw : null
     );
     form_input_text(
         'URL of web page describing app',
         'url',
-        !empty($desc->url)?$desc->url:''
+        !empty($desc->url) ? $desc->url : ''
     );
     // don't include location keywords;
     // various people may submit jobs to this app

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -225,7 +225,7 @@ 
     } else {
         form_input_text("Plan class$pc", 'variant', $variant);
     }
-    form_select("Dockerfile$sb", 'dockerfile', $sbitems, $variant_desc->dockerfile);
+    form_select("dockerfile$sb", 'dockerfile', $sbitems, $variant_desc->dockerfile);
     form_select2_multi("Application files$sb", 'app_files', $sbitems, $variant_desc->app_files);
     form_input_text(
         'Input file names<br><small>Space-separated</small>',
@@ -434,7 +434,7 @@ 
     // Note: we don't currently allow indirect file access.
     // If we did, we'd need to create job.toml to mount project dir
 
-    app_list("Variant $variant added for app $app.");
+    app_list("variant $variant added for app $app.");
 }
 
 function variant_delete() {
@@ -461,7 +461,7 @@ 
         if ($ret) {
             error_page("delete failed");
         }
-        $notice = "Variant $variant of app $app removed.";
+        $notice = "variant $variant of app $app removed.";
         app_list($notice);
     } else {
         page_head("Confirm");
@@ -491,7 +491,7 @@ 
         if ($ret) {
             error_page('delete failed');
         }
-        $notice = "App $app removed.";
+        $notice = "app $app removed.";
         app_list($notice);
     } else {
         page_head('Confirm');
@@ -556,7 +556,7 @@ 
         }
         $dir = "$buda_root/$name";
         if (file_exists($dir)) {
-            error_page("App $name already exists.");
+            error_page("app $name already exists.");
         }
         mkdir($dir);
         $desc->user_id = $user->id;

html/inc/submit_util.inc

Spacing +4 added lines, -4 removed lines

@@ -179,7 +179,7 @@ 
     foreach ($res_in_prog as $res) {
         $wus_in_prog[$res->workunitid] = true;
     }
-    unset($res_in_progress);    // does this do anything?
+    unset($res_in_progress); // does this do anything?
 
     $fp_total = 0;
     $fp_done = 0;
@@ -352,7 +352,7 @@ 
 // get the total size of output files of a batch
 //
 function batch_output_file_size($batchid) {
-    $batch_td_size=0;
+    $batch_td_size = 0;
     $wus = BoincWorkunit::enum_fields(
         'canonical_resultid',
         "batch=$batchid"
@@ -385,7 +385,7 @@ 
 }
 
 function boinc_get_wu_output_files_url($user, $wu_id) {
-    $auth_str =  md5($user->authenticator.$wu_id);
+    $auth_str = md5($user->authenticator.$wu_id);
     return "get_output.php?cmd=workunit_files&wu_id=$wu_id&auth_str=$auth_str";
 }
 
@@ -419,7 +419,7 @@ 
     if (!file_exists($path)) return null;
     $x = file_get_contents($path);
     $n = sscanf($x, "%s %d", $md5, $size);
-    if ($n != 2 || strlen($md5)!=32) {
+    if ($n != 2 || strlen($md5) != 32) {
         return null;
     }
     return [$md5, $size];

html/user/buda_submit.php

Spacing +7 added lines, -7 removed lines

@@ -85,7 +85,7 @@ 
 //
 function unzip_batch_file($user, $batch_file) {
     @mkdir("../../buda_batches");
-    for ($i=0; $i<1000; $i++) {
+    for ($i = 0; $i < 1000; $i++) {
         $batch_dir = "../../buda_batches/$i";
         $batch_dir_name = $i;
         $ret = @mkdir($batch_dir);
@@ -136,7 +136,7 @@ 
         }
         $job_files = [];
         $cmdline = '';
-        foreach(scandir("$batch_dir/$fname") as $f2) {
+        foreach (scandir("$batch_dir/$fname") as $f2) {
             if ($f2[0] == '.') continue;
             if ($f2 == 'cmdline') {
                 $cmdline = trim(file_get_contents("$batch_dir/$fname/cmdline"));
@@ -186,7 +186,7 @@ 
 function stage_input_files($batch_dir, $batch_desc, $batch_id) {
     $n = count($batch_desc->shared_files);
     $batch_desc->shared_files_phys_names = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $path = sprintf('%s/%s', $batch_dir, $batch_desc->shared_files[$i]);
         [$md5, $size] = $batch_desc->shared_file_infos[$i];
         $phys_name = sprintf('batch_%d_%s', $batch_id, $md5);
@@ -196,7 +196,7 @@ 
     foreach ($batch_desc->jobs as $job) {
         $n = count($batch_desc->unshared_files);
         $job->phys_names = [];
-        for ($i=0; $i<$n; $i++) {
+        for ($i = 0; $i < $n; $i++) {
             $path = sprintf('%s/%s/%s',
                 $batch_dir, $job->dir, $batch_desc->unshared_files[$i]
             );
@@ -245,7 +245,7 @@ 
     }
     $wrapper_cmdline = sprintf('"--dockerfile %s %s %s"',
         $variant_desc->dockerfile,
-        $wrapper_verbose?'--verbose':'',
+        $wrapper_verbose ? '--verbose' : '',
         $cmdline
     );
     $cmd = sprintf(
@@ -294,7 +294,7 @@ 
     $max_runtime_days = (double)$max_runtime_days;
     if ($max_runtime_days <= 0) error_page('bad runtime limit');
     if ($max_runtime_days > 100) error_page('bad runtime limit');
-    $max_fpops = $max_runtime_days * 4.3e9 * 86400;
+    $max_fpops = $max_runtime_days*4.3e9*86400;
 
     $exp_runtime_days = get_str('exp_runtime_days');
     if (!is_numeric($exp_runtime_days)) error_page('bad expected runtime');
@@ -304,7 +304,7 @@ 
     if ($exp_runtime_days > $max_runtime_days) {
         error_page('exp must be < max runtime');
     }
-    $exp_fpops = $exp_runtime_days * 4.3e9 * 86400;
+    $exp_fpops = $exp_runtime_days*4.3e9*86400;
 
     $app_desc = get_buda_desc($app);
 

html/user/json_form.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
 require_once('../inc/util.inc');
 require_once('../inc/sandbox.inc');
 
-function sb_file_select($user, $suffix=null) {
+function sb_file_select($user, $suffix = null) {
     $sbfiles = sandbox_file_names($user);
     $sbitems = [];
     $exp = null;

html/user/weak_auth.php

Spacing +7 added lines, -7 removed lines

@@ -30,14 +30,14 @@ 
 $master_url = master_url();
 $idx = strpos($master_url, '://');
 if ($idx) {
-    $url = substr($master_url, $idx+strlen('://'));
+    $url = substr($master_url, $idx + strlen('://'));
 } else {
     $url = $master_url;
 }
 
 // convert invalid characters into underscores
 //
-for ($i=0; $i<strlen($url); $i++) {
+for ($i = 0; $i < strlen($url); $i++) {
     $c = $url[$i];
     if (!ctype_alnum($c) && $c != '.' && $c != '-' && $c != '_') {
         $url[$i] = '_';
@@ -46,7 +46,7 @@ 
 
 //remove trailing underscore(s)
 //
-$account_file = "account_" . rtrim($url, '_') . ".xml";
+$account_file = "account_".rtrim($url, '_').".xml";
 
 page_head(tra("Account keys"));
 text_start();
@@ -58,12 +58,12 @@ 
     <p>",
     tra("This key can be used to:"),
     "<ul>
-    <li><a href=get_passwd.php>",tra("log in to your account on the web"),"</a>;
+    <li><a href=get_passwd.php>",tra("log in to your account on the web"), "</a>;
     <li>",
         tra("attach a computer to your account without using the BOINC Manager.
        To do so, install BOINC,
        create a file named %1 in the BOINC
-       data directory, and set its contents to:","<b>$account_file</b>"),"
+       data directory, and set its contents to:","<b>$account_file</b>"), "
     <p><pre>",
     htmlspecialchars(
 "<account>
@@ -77,10 +77,10 @@ 
     as described above, but cannot be used to log in to your account or change it in any way.
     If you want to attach untrusted or insecure computers to your account,
     do so using your weak account key.
-    Your weak account key is:"),"
+    Your weak account key is:"), "
     <p><pre>$weak_auth</pre><p>
     ",
-    tra("The key depends on your account's email address and password.  If you change either of these, the weak account key will change."),"
+    tra("The key depends on your account's email address and password.  If you change either of these, the weak account key will change."), "
     </td></tr></table>"
 ;
 text_end();

html/user/submit_stats.php

Spacing +7 added lines, -7 removed lines

@@ -199,25 +199,25 @@ 
     $min = 1e99;
     $max = 0;
     foreach ($results as $r) {
-        $f = $r->flops / (4.3e9 *3600);
+        $f = $r->flops/(4.3e9*3600);
         if ($f > $max) $max = $f;
         if ($f < $min) $min = $f;
         $x[] = $f;
     }
     $n = 800;
     $count = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $count[$i] = 0;
     }
     $range = $max - $min;
     foreach ($x as $f) {
-        $d = intval($n*($f-$min)/$range);
-        if ($d >= $n) $d = $n-1;
+        $d = intval($n*($f - $min)/$range);
+        if ($d >= $n) $d = $n - 1;
         $count[$d] += 1;
     }
     $data = [];
-    for ($i=0; $i<$n; $i++) {
-        $data[] = [$min+($i*$range)/$n, $count[$i]];
+    for ($i = 0; $i < $n; $i++) {
+        $data[] = [$min + ($i*$range)/$n, $count[$i]];
     }
     graph($data, 'hours', 'count');
     page_tail();
@@ -225,7 +225,7 @@ 
 
 $batch = BoincBatch::lookup_id(get_int('batch_id'));
 if (!$batch) error_page('no batch');
-switch(get_str('action')) {
+switch (get_str('action')) {
 case 'err_host':
     err_host($batch);
     break;

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -183,7 +183,7 @@
 }
 
 function flops_graph($batch) {
-    page_head("Batch $batch->id job runtimes");
+    page_head("batch $batch->id job runtimes");
     echo "
     <p>
     Runtimes of completed jobs, normalized to an average (4.3 GFLOPS) computer.