Issues in class.jetpack-sync-options.php - Fixed Issues - Inspection of "refactor all of the things" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/sync-rest-2 ( 5112c0 )

unknown

created 2016-03-14 15:58 UTC

class.jetpack-sync-options.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


class Jetpack_Sync_Options {

	static $options = array(
		'blogname',
	);

	static $sync = array();
	static $delete = array();

	static function init() {
		foreach ( self::$options as $option ) {
			self::register( $option );
		}
	}

	static function register( $option ) {
		add_action( "add_option_{$option}",    array( __CLASS__, 'add_option'   ) );
		add_action( "update_option_{$option}", array( __CLASS__, 'update_option' ) );
		add_action( "delete_option_{$option}", array( __CLASS__, 'delete_option' ) );
	}

	static function add_option( $option ) {
		self::$sync[] = $option;
	}

	static function update_option() {
		$option = current_filter();
		$prefix = 'update_option_';
		if ( 0 !== strpos( $option, $prefix ) ) {
			return;
		}
		$option = substr( $option, strlen( $prefix ) );
		self::$sync[] = $option;
	}

	static function delete_option( $option ) {
		self::$delete[] = $option;
	}

	static function sync() {
		return self::values( self::get_options_to_sync() );
	}

	static function sync_sometimes() {

		// Since there are option in the sync we know that things have changed.
		if( ! empty ( self::$sync ) ) {
			return self::sync_all();
		}

		$values           = self::values( self::$options );
		$check_sum        = self::get_check_sum( $values );

		if ( Jetpack_Options::get_option( 'options_check_sum' ) !== $check_sum ) {
			return self::sync_all( $values, $check_sum );
		}
		return null;
	}

	static function sync_all( $values = null, $check_sum = null ) {
		if ( is_null( $values ) ) {
			$values           = self::values( self::$options );
$a = "a";
$ab = "ab";
$abc = "abc";
		}
		if( is_null( $check_sum ) ) {
			$check_sum = self::get_check_sum( $values );
		}
		Jetpack_Options::update_option( 'options_check_sum', $check_sum );
		return $values;
	}

	static function options_to_sync() {
		return array_unique( self::$sync );
	}

	static function get_check_sum( $values ) {
		return crc32( self::get_query_string( $values ) );
	}

	static function get_query_string( $values ) {
		return build_query( $values );
	}

	static function values( $sync = array() ) {
		$values = array();
		if ( ! empty( $sync ) ) {
			foreach ( $sync as $key ) {
				$values[ $key ] = self::get( $key );
			}
		}
		return $values;
	}

	static function get_options_to_sync() {
		return array_unique( self::$sync );
	}

	static function sync_delete() {
		return array_unique( self::$delete );
	}

	static function get( $constant ) {
		return get_option( $constant );
	}
}


1		<?php
2
3
4		class Jetpack_Sync_Options {
5
6		static $options = array(
7		'blogname',
8		);
9
10		static $sync = array();
11		static $delete = array();
12
13		static function init() {
14		foreach ( self::$options as $option ) {
15		self::register( $option );
16		}
17		}
18
19		static function register( $option ) {
20		add_action( "add_option_{$option}", array( __CLASS__, 'add_option' ) );
21		add_action( "update_option_{$option}", array( __CLASS__, 'update_option' ) );
22		add_action( "delete_option_{$option}", array( __CLASS__, 'delete_option' ) );
23		}
24
25		static function add_option( $option ) {
26		self::$sync[] = $option;
27		}
28
29	View Code Duplication	static function update_option() {
30		$option = current_filter();
31		$prefix = 'update_option_';
32		if ( 0 !== strpos( $option, $prefix ) ) {
33		return;
34		}
35		$option = substr( $option, strlen( $prefix ) );
36		self::$sync[] = $option;
37		}
38
39		static function delete_option( $option ) {
40		self::$delete[] = $option;
41		}
42
43		static function sync() {
44		return self::values( self::get_options_to_sync() );
45		}
46
47	View Code Duplication	static function sync_sometimes() {
48
49		// Since there are option in the sync we know that things have changed.
50		if( ! empty ( self::$sync ) ) {
51		return self::sync_all();
52		}
53
54		$values = self::values( self::$options );
55		$check_sum = self::get_check_sum( $values );
56
57		if ( Jetpack_Options::get_option( 'options_check_sum' ) !== $check_sum ) {
58		return self::sync_all( $values, $check_sum );
59		}
60		return null;
61		}
62
63	View Code Duplication	static function sync_all( $values = null, $check_sum = null ) {
64		if ( is_null( $values ) ) {
65		$values = self::values( self::$options );
		0 ignored issues – show Coding Style introduced 2016-03-11 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned correctly; expected 1 space but found 11 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
66		}
67		if( is_null( $check_sum ) ) {
68		$check_sum = self::get_check_sum( $values );
69		}
70		Jetpack_Options::update_option( 'options_check_sum', $check_sum );
71		return $values;
72		}
73
74		static function options_to_sync() {
75		return array_unique( self::$sync );
76		}
77
78		static function get_check_sum( $values ) {
79		return crc32( self::get_query_string( $values ) );
80		}
81
82		static function get_query_string( $values ) {
83		return build_query( $values );
84		}
85
86		static function values( $sync = array() ) {
87		$values = array();
88		if ( ! empty( $sync ) ) {
89		foreach ( $sync as $key ) {
90		$values[ $key ] = self::get( $key );
91		}
92		}
93		return $values;
94		}
95
96		static function get_options_to_sync() {
97		return array_unique( self::$sync );
98		}
99
100		static function sync_delete() {
101		return array_unique( self::$delete );
102		}
103
104		static function get( $constant ) {
105		return get_option( $constant );
106		}
107		}
108

Automattic / jetpack

Push — add/sync-rest-2 ( 5112c0 )

class.jetpack-sync-options.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like