Test Failed
Pull Request — master (#26)
by Christopher
02:34
created

xsDurationTest   A

Complexity

Total Complexity 8

Size/Duplication

Total Lines 82
Duplicated Lines 95.12 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 2
Bugs 0 Features 1
Metric Value
wmc 8
c 2
b 0
f 1
lcom 1
cbo 2
dl 78
loc 82
rs 10

6 Methods

Rating   Name   Duplication   Size   Complexity  
A testxsDurationValid() 9 9 2
A testxsDurationValidDataProvider() 14 14 1
A testxsDurationInvalid() 10 10 2
A testxsDurationInvalidDataProvider() 15 15 1
A setUp() 4 4 1
A tearDown() 1 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
4
namespace AlgoWeb\xsdTypes;
5
6
/**
7
 * Generated Test Class.
8
 */
9 View Code Duplication
class xsDurationTest extends \PHPUnit_Framework_TestCase
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
10
{
11
    /**
12
     * @dataProvider testxsDurationValidDataProvider
13
     * @param mixed $input
14
     * @param mixed $message
15
     */
16
    public function testxsDurationValid($input, $message)
17
    {
18
        try {
19
            $d = new xsDuration($input);
20
            $s = (string)$d;
0 ignored issues
show
Unused Code introduced by
$s is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
21
        } catch (\Exception $e) {
22
            $this->fail($message . ' with Exception ' . $e->getMessage());
23
        }
24
    }
25
26
    public function testxsDurationValidDataProvider()
27
    {
28
        return array(
29
            array('P2Y6M5DT12H35M30S', '2 years, 6 months, 5 days, 12 hours, 35 minutes, 30 seconds'),
30
            array('P1DT2H', '1 day, 2 hours'),
31
            array('P20M', '20 months (the number of months can be more than 12)'),
32
            array('PT20M', '20 minutes'),
33
            array('P0Y20M0D', '20 months (0 is permitted as a number, but is not required)'),
34
            array('P0Y', '0 years'),
35
            array('-P60D', 'minus 60 days'),
36
            array('PT1M30.5S', '1 minute, 30.5 seconds'),
37
38
        );
39
    }
40
41
    /**
42
     * @dataProvider testxsDurationInvalidDataProvider
43
     * @param mixed $input
44
     * @param mixed $message
45
     */
46
    public function testxsDurationInvalid($input, $message)
47
    {
48
        try {
49
            $d = new xsDuration($input);
50
            $s = (string)$d;
51
            $this->fail($message);
52
        } catch (\Exception $e) {
0 ignored issues
show
Coding Style Comprehensibility introduced by
Consider adding a comment why this CATCH block is empty.
Loading history...
53
        }
54
        $this->assertEquals('', $s, $message);
0 ignored issues
show
Bug introduced by
The variable $s does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
55
    }
56
57
    public function testxsDurationInvalidDataProvider()
58
    {
59
        return array(
60
            array('P-20M', 'the minus sign must appear first'),
61
            array('P20MT', 'no time items are present, so "T" must not be present'),
62
            array('P1YM5D', 'no value is specified for months, so "M" must not be present'),
63
            array('P15.5Y', 'only the seconds can be expressed as a decimal'),
64
            array('P1D2H', '"T" must be present to separate days and hours'),
65
            array('1Y2M', '"P" must always be present'),
66
            array('P2M1Y', 'years must appear before months'),
67
            array('P', 'at least one number and designator are required'),
68
            array('PT15.S', 'at least one digit must follow the decimal point if it appears'),
69
            array('', 'an empty value is not valid, unless xsi:nil is used'),
70
        );
71
    }
72
73
    /**
74
     * Sets up the fixture, for example, opens a network connection.
75
     * This method is called before a test is executed.
76
     */
77
    protected function setUp()
78
    {
79
        parent::setUp();
80
    }
81
82
    /**
83
     * Tears down the fixture, for example, closes a network connection.
84
     * This method is called after a test is executed.
85
     */
86
    protected function tearDown()
87
    {
88
        parent::tearDown();
89
    }
90
}
91