Arcanedev\LaravelHtml\Traits\FormAccessible

Complexity

Total Complexity

8

Size/Duplication

Total Lines	93
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

96%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getFormValue()	0	19	4
A	hasFormMutator()	0	12	1
A	mutateFormAttribute()	0	4	1
A	getReflection()	0	8	2

<?php namespace Arcanedev\LaravelHtml\Traits;

use ReflectionClass;
use ReflectionMethod;

/**
 * Class     FormAccessible
 *
 * @package  Arcanedev\LaravelHtml\Traits
 * @author   ARCANEDEV <arcanedev.maroc@gmail.com>
 */
trait FormAccessible
{
    /* ------------------------------------------------------------------------------------------------
     |  Properties
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * A cached ReflectionClass instance for $this
     *
     * @var ReflectionClass
     */
    protected $reflection;

    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * @param string $key
     *
     * @return mixed
     */
    public function getFormValue($key)
    {
        $value = $this->getAttributeFromArray($key);

It seems like getAttributeFromArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // If the attribute is listed as a date, we will convert it to a DateTime
        // instance on retrieval, which makes it quite convenient to work with
        // date fields without having to create a mutator for each property.
        if (in_array($key, $this->getDates())) {

It seems like getDates() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if ( ! is_null($value)) {
                $value = $this->asDateTime($value);

It seems like asDateTime() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        }

        if ($this->hasFormMutator($key)) {
            return $this->mutateFormAttribute($key, $value);
        }

        return $value;
    }

    /* ------------------------------------------------------------------------------------------------
     |  Other Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Check if has a form mutator.
     *
     * @param  string  $key
     *
     * @return bool
     */
    protected function hasFormMutator($key)
    {
        $methods = $this->getReflection()
            ->getMethods(ReflectionMethod::IS_PUBLIC);

        $mutator = collect($methods)
            ->first(function ($index, ReflectionMethod $method) use ($key) {
                return $method->getName() === 'form' . str_studly($key) . 'Attribute';

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

            });

        return (bool) $mutator;
    }

    /**
     * Mutate the form attribute.
     *
     * @param  string  $key
     * @param  mixed   $value
     *
     * @return mixed
     */
    private function mutateFormAttribute($key, $value)
    {
        return $this->{'form' . str_studly($key) . 'Attribute'}($value);
    }

    /**
     * Get a ReflectionClass Instance
     *
     * @return ReflectionClass
     */
    protected function getReflection()
    {
        if ( ! $this->reflection) {
            $this->reflection = new ReflectionClass($this);
        }

        return $this->reflection;
    }
}