ContentPostProcAll::replaceAssets() - Code Metrics - Inspection of "use middleware for versions >= 9.5" - AOEpeople/asdis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7f78b2...c07d7e )

unknown

created 2021-03-03 06:57 UTC

ContentPostProcAll::replaceAssets() A

↳ Parent: ContentPostProcAll

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php
namespace Aoe\Asdis\Middleware;

use Aoe\Asdis\Domain\Model\Asset\Collection;
use Aoe\Asdis\Domain\Model\Page;
use Aoe\Asdis\System\Configuration\Provider;
use Aoe\Asdis\System\Log\Logger;
use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use TYPO3\CMS\Core\Http\HtmlResponse;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Extbase\Object\ObjectManager;

class ContentPostProcAll implements MiddlewareInterface
{
    /**
     * @var \Aoe\Asdis\Domain\Model\Page
     */
    private $page;

    /**
     * @param array $params
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController $pObj
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return void
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $response = $handler->handle($request);

        if ($this->getConfigurationProvider()->isDefaultHookHandlingDisabled()) {
            return $response;
        }

        try {
            $this->setPageObject($GLOBALS['TSFE']);
            $this->scrapeAndReplace();
            $response = new HtmlResponse($this->page->getPageObject()->content);
        } catch(\Exception $e) {
            $this->getLogger()->logException(__METHOD__, $e);
        }

        return $response;
    }

    /**
	 * @return Provider
	 */
	protected function getConfigurationProvider()
	{
        $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
        return $objectManager->get(Provider::class);
	}

    /**
	 * @return Logger
	 */
	protected function getLogger()
	{
        $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
        return $objectManager->get(Logger::class);
	}

    /**
     * @return void
     */
    protected function scrapeAssets()
    {
        $this->page->scrapeAssets();
    }

    /**
     * @return void
     */
    protected function replaceAssets()
    {
        $this->page->replaceAssets();
    }

    /**
     * Scrapes and replaces the assets of the current page.
     *
     * @return void
     */
    protected function scrapeAndReplace()
    {
        $this->scrapeAssets();
        $this->replaceAssets();
    }

    /**
     * @param \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController $pObj
     */
    protected function setPageObject(\TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController $pObj)
    {
        $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
        /** @var \Aoe\Asdis\Domain\Model\Page $page */
        $page = $objectManager->get(Page::class);
        $page->setAssets($objectManager->get(Collection::class));
        $page->setPageObject($pObj);
        $this->page = $page;
    }
}

1			<?php
2			namespace Aoe\Asdis\Middleware;
3
4			use Aoe\Asdis\Domain\Model\Asset\Collection;
5			use Aoe\Asdis\Domain\Model\Page;
6			use Aoe\Asdis\System\Configuration\Provider;
7			use Aoe\Asdis\System\Log\Logger;
8			use Psr\Http\Message\ResponseFactoryInterface;
9			use Psr\Http\Message\ResponseInterface;
10			use Psr\Http\Message\ServerRequestInterface;
11			use Psr\Http\Server\MiddlewareInterface;
12			use Psr\Http\Server\RequestHandlerInterface;
13			use TYPO3\CMS\Core\Http\HtmlResponse;
14			use TYPO3\CMS\Core\Utility\GeneralUtility;
15			use TYPO3\CMS\Extbase\Object\ObjectManager;
16
17			class ContentPostProcAll implements MiddlewareInterface
18			{
19			/**
20			* @var \Aoe\Asdis\Domain\Model\Page
21			*/
22			private $page;
23
24			/**
25			* @param array $params
			0 ignored issues – show Bug introduced 2021-03-03 07:09 UTC by Report Bug Copy Issue Report There is no parameter named `$params`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
26			* @param \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController $pObj
			0 ignored issues – show Bug introduced 2016-01-11 09:16 UTC by Report Bug Copy Issue Report There is no parameter named `$pObj`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
27			* @return void
28			*/
29			public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
30			{
31			$response = $handler->handle($request);
32
33			if ($this->getConfigurationProvider()->isDefaultHookHandlingDisabled()) {
34			return $response;
35			}
36
37			try {
38			$this->setPageObject($GLOBALS['TSFE']);
39			$this->scrapeAndReplace();
40			$response = new HtmlResponse($this->page->getPageObject()->content);
41			} catch(\Exception $e) {
42			$this->getLogger()->logException(__METHOD__, $e);
43			}
44
45			return $response;
46			}
47
48			/**
49			* @return Provider
50			*/
51			protected function getConfigurationProvider()
52			{
53			$objectManager = GeneralUtility::makeInstance(ObjectManager::class);
54			return $objectManager->get(Provider::class);
55			}
56
57			/**
58			* @return Logger
59			*/
60			protected function getLogger()
61			{
62			$objectManager = GeneralUtility::makeInstance(ObjectManager::class);
63			return $objectManager->get(Logger::class);
64			}
65
66			/**
67			* @return void
68			*/
69			protected function scrapeAssets()
70			{
71			$this->page->scrapeAssets();
72			}
73
74			/**
75			* @return void
76			*/
77			protected function replaceAssets()
78			{
79			$this->page->replaceAssets();
80			}
81
82			/**
83			* Scrapes and replaces the assets of the current page.
84			*
85			* @return void
86			*/
87			protected function scrapeAndReplace()
88			{
89			$this->scrapeAssets();
90			$this->replaceAssets();
91			}
92
93			/**
94			* @param \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController $pObj
95			*/
96			protected function setPageObject(\TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController $pObj)
97			{
98			$objectManager = GeneralUtility::makeInstance(ObjectManager::class);
99			/** @var \Aoe\Asdis\Domain\Model\Page $page */
100			$page = $objectManager->get(Page::class);
101			$page->setAssets($objectManager->get(Collection::class));
102			$page->setPageObject($pObj);
103			$this->page = $page;
104			}
105			}

AOEpeople / asdis

Push — master ( 7f78b2...c07d7e )

ContentPostProcAll::replaceAssets() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like