HasLoginsAndDevices::attempts() - Code Metrics - Inspection of "Refactoring and tests" - 404labfr/laravel-auth-checker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b6d9d8...5df2ff )

by Marceau

created 2017-03-27 12:09 UTC

HasLoginsAndDevices::attempts() A

↳ Parent: HasLoginsAndDevices

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Lab404\AuthChecker\Models;

use Illuminate\Database\Eloquent\Relations\HasMany;

trait HasLoginsAndDevices
{
    /**
     * @param   void
     * @return  HasMany
     */
    public function logins()
    {
        return $this->hasMany(Login::class)->where('type', Login::TYPE_LOGIN);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param   void
     * @return  HasMany
     */
    public function attempts()
    {
        return $this->hasMany(Login::class)->where('type', Login::TYPE_ATTEMPT);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param   void
     * @return  HasMany
     */
    public function lockouts()
    {
        return $this->hasMany(Login::class)->where('type', Login::TYPE_LOCKOUT);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param   void
     * @return  HasMany
     */
    public function devices()
    {
        return $this->hasMany(Device::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param   void
     * @return  bool
     */
    public function hasDevices()
    {
        return $this->devices && $this->devices->isNotEmpty();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1			<?php
2
3			namespace Lab404\AuthChecker\Models;
4
5			use Illuminate\Database\Eloquent\Relations\HasMany;
6
7			trait HasLoginsAndDevices
8			{
9			/**
10			* @param void
11			* @return HasMany
12			*/
13			public function logins()
14			{
15			return $this->hasMany(Login::class)->where('type', Login::TYPE_LOGIN);
			0 ignored issues – show Bug introduced 2017-03-27 12:14 UTC by Report Bug Copy Issue Report It seems like `hasMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16			}
17
18			/**
19			* @param void
20			* @return HasMany
21			*/
22			public function attempts()
23			{
24			return $this->hasMany(Login::class)->where('type', Login::TYPE_ATTEMPT);
			0 ignored issues – show Bug introduced 2017-03-27 12:14 UTC by Report Bug Copy Issue Report It seems like `hasMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			}
26
27			/**
28			* @param void
29			* @return HasMany
30			*/
31			public function lockouts()
32			{
33			return $this->hasMany(Login::class)->where('type', Login::TYPE_LOCKOUT);
			0 ignored issues – show Bug introduced 2017-03-27 12:14 UTC by Report Bug Copy Issue Report It seems like `hasMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			}
35
36			/**
37			* @param void
38			* @return HasMany
39			*/
40			public function devices()
41			{
42			return $this->hasMany(Device::class);
			0 ignored issues – show Bug introduced 2017-03-25 15:31 UTC by Report Bug Copy Issue Report It seems like `hasMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43			}
44
45			/**
46			* @param void
47			* @return bool
48			*/
49			public function hasDevices()
50			{
51			return $this->devices && $this->devices->isNotEmpty();
			0 ignored issues – show Bug introduced 2017-03-27 12:14 UTC by Report Bug Copy Issue Report The property `devices` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
52			}
53			}
54

404labfr / laravel-auth-checker

Push — master ( b6d9d8...5df2ff )

HasLoginsAndDevices::attempts() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like