TerminateSessionsService::run() - Code Metrics - Inspection of "Add session history" - 2amigos/yii2-usuario - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#361)

unknown

created 2019-11-30 15:04 UTC

TerminateSessionsService::run() A

↳ Parent: TerminateSessionsService

Complexity

Conditions	5
Paths	12

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	0
cts	20
cp	0
rs	9.2248
c	0
b	0
f	0
cc	5
nc	12
nop	0
crap	30

<?php

/*
 * This file is part of the 2amigos/yii2-usuario project.
 *
 * (c) 2amigOS! <http://2amigos.us/>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

namespace Da\User\Service\SessionHistory;


class TerminateSessionsService implements TerminateSessionsServiceInterface
{
    protected $sessionIds;

    public function __construct(array $sessionIds)
    {
        $this->sessionIds = $sessionIds;
    }

    public function run()
    {
        $currentSessionId = session_id();
        if (session_status() === PHP_SESSION_ACTIVE) {
            session_write_close();
        }

        foreach ($this->sessionIds as $sessionId) {
            if ($sessionId === $currentSessionId) {
                $currentSessionId = null;
            }

            session_id($sessionId);
            session_start();
            session_destroy();
        }

        if ($currentSessionId) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            session_id($currentSessionId);
        }
        session_start();

        return true;
    }
}


1			<?php
2
3			/*
4			* This file is part of the 2amigos/yii2-usuario project.
5			*
6			* (c) 2amigOS! <http://2amigos.us/>
7			*
8			* For the full copyright and license information, please view
9			* the LICENSE file that was distributed with this source code.
10			*/
11
12			namespace Da\User\Service\SessionHistory;
13
14
15			class TerminateSessionsService implements TerminateSessionsServiceInterface
16			{
17			protected $sessionIds;
18
19			public function __construct(array $sessionIds)
20			{
21			$this->sessionIds = $sessionIds;
22			}
23
24			public function run()
25			{
26			$currentSessionId = session_id();
27			if (session_status() === PHP_SESSION_ACTIVE) {
28			session_write_close();
29			}
30
31			foreach ($this->sessionIds as $sessionId) {
32			if ($sessionId === $currentSessionId) {
33			$currentSessionId = null;
34			}
35
36			session_id($sessionId);
37			session_start();
38			session_destroy();
39			}
40
41			if ($currentSessionId) {
			0 ignored issues – show Bug Best Practice introduced 2019-11-14 18:23 UTC by Report Bug Copy Issue Report The expression `$currentSessionId` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
42			session_id($currentSessionId);
43			}
44			session_start();
45
46			return true;
47			}
48			}
49

2amigos / yii2-usuario

Pull Request — master (#361)

TerminateSessionsService::run() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like